From owner-svn-ports-all@freebsd.org Wed Mar 25 09:43:10 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA64827BFCE; Wed, 25 Mar 2020 09:43:10 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48nNTS2Rkmz3RJZ; Wed, 25 Mar 2020 09:43:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id E4B02CFEC; Wed, 25 Mar 2020 09:42:56 +0000 (UTC) Date: Wed, 25 Mar 2020 09:42:56 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Fernando Apestegu??a , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r529058 - in head/games/cursive: . files Message-ID: <20200325094256.GB84692@FreeBSD.org> References: <202003241755.02OHtmlc091932@repo.freebsd.org> <20200325081902.z4g34mdxmnholnbr@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325081902.z4g34mdxmnholnbr@atuin.in.mat.cc> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 09:43:11 -0000 On Wed, Mar 25, 2020 at 09:19:02AM +0100, Mathieu Arnold wrote: > On Tue, Mar 24, 2020 at 05:55:48PM +0000, Fernando Apestegu?a wrote: > > > > Deleted: > > head/games/cursive/files/ > > + > > +post-patch: > > + @${REINPLACE_CMD} -e 's|/usr/games/||g' ${WRKSRC}/cursive.6 > > So, you removed the patch-cursive.6 and replaced it by a static sed > line, which goes against our policies. Which brings us back to the pile of problems with this, outlined by mandree@ earlier* on 12 Jan 2020 (portmgr@ should have a copy), and particularly item #4: 4) I'd also like to generalize the discussion. That new requirement "REINPLACE_CMD only for variable content", which was not discussed widely where I'd seen it, does not meet my approval. Please point me to the discussion and majority vote if there was one. I'll be listening to sustainable arguments on why we can't use REINPLACE_CMD any more if it saves so many inodes, so many program calls, and whatnot, but my fantasy does not extend that far. So my conclusion is docs/ changeset r53173 has newly imposed that restriction with no plausible rationale given, without any discussion or vote, and should be reverted. I firmy share this opinion and couldn't have said it better. Both patches and sed(1) could be abused or use efficiently, but that comes with experience and learning, not by enforcing policies like this one which goes way too far by forbidding correct and appropriate sed(1)- patching simply because someone does not like it. ./danfe *) Message-ID: <1c55d025-86c0-3b36-c937-987336de575e@FreeBSD.org>