From owner-freebsd-arch@FreeBSD.ORG Fri Jun 22 02:14:15 2007 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7508616A46B for ; Fri, 22 Jun 2007 02:14:15 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 5AC5813C45E for ; Fri, 22 Jun 2007 02:14:15 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 61038 invoked from network); 21 Jun 2007 23:26:31 -0000 Received: from ppp-71-139-42-13.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.42.13) by root.org with ESMTPA; 21 Jun 2007 23:26:31 -0000 Message-ID: <467B091F.6070008@root.org> Date: Thu, 21 Jun 2007 16:26:23 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070511) MIME-Version: 1.0 To: Lars Engels References: <46756BBE.5030603@root.org> <20070621155044.GD17194@e.0x20.net> <467AA6C6.8090607@root.org> <20070621222836.GC16887@e.0x20.net> In-Reply-To: <20070621222836.GC16887@e.0x20.net> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: acpi@freebsd.org, arch@freebsd.org, current Subject: Re: patch: acpi usermode suspend API change X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2007 02:14:15 -0000 Lars Engels wrote: > On Thu, Jun 21, 2007 at 09:26:46AM -0700, Nate Lawson wrote: >> Lars Engels wrote: >>> Nate, >>> >>> thanks for your patch. >>> But after applying it on a recent -Current I get a lot of kernel messages >>> like these: >>> Jun 21 17:48:27 maggie kernel: apm34 opened clone 0xc457fd00 >>> Jun 21 17:48:27 maggie kernel: apm34 closed clone 0xc457fd00 >>> Jun 21 17:48:32 maggie kernel: apm35 opened clone 0xc457ee40 >>> Jun 21 17:48:32 maggie kernel: apm35 closed clone 0xc457ee40 >>> Jun 21 17:48:37 maggie kernel: apm36 opened clone 0xc457ec40 >>> Jun 21 17:48:37 maggie kernel: apm36 closed clone 0xc457ec40 >>> Jun 21 17:48:42 maggie kernel: apm37 opened clone 0xc457fc40 >>> Jun 21 17:48:42 maggie kernel: apm37 closed clone 0xc457fc40 >>> Jun 21 17:48:47 maggie kernel: apm38 opened clone 0xc433b6c0 >>> Jun 21 17:48:47 maggie kernel: apm38 closed clone 0xc433b6c0 >>> Jun 21 17:48:52 maggie kernel: apm39 opened clone 0xc433b240 >> Thanks for testing! Those were there to assist in debugging if people >> had any problems. >> >>> Additionally, pressing the power button only generates this: >>> Jun 21 17:50:03 maggie kernel: acpi: request to enter state S5 failed >>> >>> I need to run 'shutdown -p ' to power the system down. >> This was already fixed in the updated patch that I plan to commit today. >> It's attached or you can just wait for the commit to get it. > > Okay, I cannot test this today, so I will take your committed version > tomorrow. Patch has been committed, along with an addition to use a taskq to clean up the extra devices. You should find that all this works fine and /dev/apm is cleaned up. To upgrade, you should install the /etc/ scripts, acpiconf, and the acpi kernel module. Installworld/mergemaster take care of this. Old binaries of acpiconf will continue to work fine with just a message printed once on console that the old API is deprecated. -- Nate