Date: Tue, 07 Apr 2015 19:13:43 +0200 From: John Marino <freebsd.contact@marino.st> To: Bryan Drewery <bdrewery@FreeBSD.org>, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383184 - in head/devel/libc++: . files Message-ID: <55241047.50102@marino.st> In-Reply-To: <55240C73.9050209@FreeBSD.org> References: <201504040022.t340MwUc082274@svn.freebsd.org> <55240C73.9050209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/7/2015 18:57, Bryan Drewery wrote: > On 4/3/2015 7:22 PM, John Marino wrote: >> Author: marino >> Date: Sat Apr 4 00:22:57 2015 >> New Revision: 383184 >> URL: https://svnweb.freebsd.org/changeset/ports/383184 >> >> Log: >> devel/libc++: Mainly fix DragonFly support. >> >> This port was originally fixed in dports using alias:10 but this fix >> was faulty. The libc++ headers reference __FreeBSD__ so alias won't >> work. It needs to be patched to check __DragonFly__, including a file >> that was the subject of EXTRA_PATCHES. > > Can you please upstream the DragonFly support? > > I am working on getting dim's patch into the port to update it and > conflicting with all of this. Had I create the patch a week later, then I would have had to rework my patch. Sometimes this happen. > I think it will be simpler to use CPPFLAGS+=-D__FreeBSD__ to cover most > of these cases without patches. Well, it didn't. >> Moreover, the port was installing the .orig files left over from >> patching. I remove these in post-patch now. > > I don't think this is a problem worth fixing. check-plist already > ignores .orig files. Well, it's fixed now so the fix isn't work removing.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55241047.50102>