Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Aug 2013 15:28:15 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Hajimu UMEMOTO <ume@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r324593 - head/sysutils/gkrellm2
Message-ID:  <20130811152815.GA35034@FreeBSD.org>
In-Reply-To: <201308111523.r7BFNpn0099666@svn.freebsd.org>
References:  <201308111523.r7BFNpn0099666@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 11, 2013 at 03:23:51PM +0000, Hajimu UMEMOTO wrote:
> New Revision: 324593
> URL: http://svnweb.freebsd.org/changeset/ports/324593
> 
> @@ -14,8 +14,8 @@ COMMENT=	A GTK based system monitor

You could have dropped indefinite article from COMMENT while here.

>  LICENSE=	GPLv3
>  LICENSE_FILE=	${WRKSRC}/COPYING
>  
> +USES+=		gmake pkgconfig

Any reason to append to USES instead of simply assigning it?

> -Author:	Bill Wilson bill@gkrellm.net
> -WWW:    http://gkrellm.net
> +Author: Bill Wilson bill@gkrellm.net
> +WWW: http://gkrellm.net

We generally do not support listing author explicitly when there is WWW page
available.  You should have also terminated URL with a slash as advised by
PH, section 3.2.1.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130811152815.GA35034>