From owner-freebsd-current@FreeBSD.ORG  Fri May 30 02:29:00 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 60E9D37B401; Fri, 30 May 2003 02:29:00 -0700 (PDT)
Received: from stork.mail.pas.earthlink.net (stork.mail.pas.earthlink.net
	[207.217.120.188])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8BD8043FBD; Fri, 30 May 2003 02:28:59 -0700 (PDT)
	(envelope-from tlambert2@mindspring.com)
Received: from user-38lc0lu.dialup.mindspring.com ([209.86.2.190]
	helo=mindspring.com)
	by stork.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128)
	(Exim 3.33 #1)	id 19LgC2-0003KF-00; Fri, 30 May 2003 02:28:59 -0700
Message-ID: <3ED723FF.CBF45577@mindspring.com>
Date: Fri, 30 May 2003 02:27:27 -0700
From: Terry Lambert <tlambert2@mindspring.com>
X-Mailer: Mozilla 4.79 [en] (Win98; U)
X-Accept-Language: en
MIME-Version: 1.0
To: David Xu <davidxu@freebsd.org>
References: <20030529164240.X769@gravy.homeunix.net>
	<3ED71E39.A0F8EBC3@mindspring.com> <000701c3268b$86faaa30$f001a8c0@davidw2k>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a418083a120f3855be6f3f66e5919a48133ca473d225a0f487350badd9bab72f9c350badd9bab72f9c
cc: Bryan Liesner <bleez@verizon.net>
cc: freebsd-current@freebsd.org
Subject: Re: panic: kern/52718
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2003 09:29:00 -0000

David Xu wrote:
> > This was caused by rev. 1.3 of a commit by Jeff Robertson to
> > kern_utmx.c.  The problem is that the proc struct is not locked
> > for:
> >
> >         FOREACH_THREAD_IN_PROC(td->td_proc, td0)
> >
> > in the lock and unlock.
> >
> > Either lock the proc before and unlock it after this, in both
> > _utmx_lock() and _utmx_unlock(), or revert the code to 1.2.
> 
> kern_sig.c has same issue in several places.

Just looked... YUCK!  The Process group code and the code in
the filt_sigdetach() have got to be what you are talking about,
right?

I'm constantly surprised at some of the race windows I find in
production code (not just FreeBSD), that are just waiting there
to chew someone's leg off the first chance they get... 8-(.

-- Terry