Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Feb 2019 15:16:53 -0800
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        rgrimes@freebsd.org
Cc:        Matt Macy <mmacy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r344487 - in head/sys: conf gnu/gcov
Message-ID:  <201902232316.x1NNGrhD089735@slippy.cwsent.com>
In-Reply-To: Message from "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> of "Sat, 23 Feb 2019 13:52:45 -0800." <201902232152.x1NLqjKG032128@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <201902232152.x1NLqjKG032128@pdx.rh.CN85.dnsmgr.net>, 
"Rodney W. Gri
mes" writes:
> > > Author: mmacy
> > > Date: Sat Feb 23 21:14:00 2019
> > > New Revision: 344487
> > > URL: https://svnweb.freebsd.org/changeset/base/344487
> > > 
> > > Log:
> > >   gcov support
> > >   
> > >   add gcov support and export results as files in debugfs
> > >   
> > >   Reviewed by:	hps@
> > >   MFC after:	1 week
> > >   Sponsored by:	iX Systems
> > >   Differential Revision:	https://reviews.freebsd.org/D19260
>
> And an additional nit, we can never becomre GPL free
> if we continue to add GPL code to the system.

+1 on adding GPL code to the system.

The thing that comes to mind with this commit is that we generally try 
to commit to the vendor branch externally obtained code and merge. That 
this was committed directly suggests that we will be the maintainers of 
this code, also suggesting that this GPL code is here to stay. Or, are 
there plans to replace this with BSD licensed code.

As this is external, obtained from should have been documented in the 
commit message.

Ccould this not be put into ports? Those wishing to use this feature 
could install it as desired.

Not to heap it on, just a bunch of questions coming to mind as I write 
this: What about DTrace, can't we do the same with it? Which once again 
argues against GPL in base, especially the kernel.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902232316.x1NNGrhD089735>