From owner-svn-ports-all@freebsd.org Tue Jan 26 18:08:27 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 896A6A6ED5F for ; Tue, 26 Jan 2016 18:08:27 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ig0-x230.google.com (mail-ig0-x230.google.com [IPv6:2607:f8b0:4001:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A88A1037 for ; Tue, 26 Jan 2016 18:08:27 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: by mail-ig0-x230.google.com with SMTP id mw1so57651961igb.1 for ; Tue, 26 Jan 2016 10:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helfman-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=mdbr58il4oQT3bgW+Nbcpbrs+kqffQ1NCYxG9gbdiOk=; b=fzE7WDn5dIX4K1rITavMn5LizWVau4iKDK4q+ZzE4jw+aOrsECMpMdLmhGYKpvRgPU 6I59W01I6lx8SacBTZAUBmhjD4LVzZMLzlSYF43Sk9YW5zMwGX6R3AM+eT23MMTBKjaW AIXoXNzNj/ASCHXnOoYy47dPau21mnchXdwCdYB+hcrf2UOhqx8ZAi3e5BFztLS0NMG/ lY1SNDAJd1NIqwP8JvH0Qw5c6Q0gBfOwQRPR44hMs/YmzOC7Tar61fe2MyyjaZ5ytF8C yCpbzJX0uB2PCMHN3tippS+Ry2wdLUwXazNC5lXNSNI+JY7y2HiDCOK+47kYRZ0xsk5+ sE8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=mdbr58il4oQT3bgW+Nbcpbrs+kqffQ1NCYxG9gbdiOk=; b=Pw4IgPJlkYuywoPbf2SkN+nxHz1PApTERDtRVHAbJR2mUz9wtE66QpPuDlXrXR8bNr XR/GpEMJlzQ8u1VlYx9GooQnZoU3gXwc6EKqEG0CoDqYvX8EelO2ARlC5NtUpx9BFZGR GbnMScZg1+GizUWFreKCJNXbYo8uJILF1/XIcgBH7iTNbBpLVt6yo83e7um2KGqAbXs6 35rvQcFn1mPzPhjfrPhABY0gmjCQHgw5f3xtvx1Cm5PvyoJh8TwgbVJKn52AuPptHGsc 5HK89YE+JQj9EMSc+RHmR3eIYQg9SSnh3okmH+zCXv3CdptndHj8fYnS6h6DmEbPtLZg n7tg== X-Gm-Message-State: AG10YORprFPqzSD9dKaz7bccLxIKZujubFIPX3ZLri709AaFD3Cfx2XczRXC64wZYhvByvnlxmEM1jQnVmXDQQ== MIME-Version: 1.0 X-Received: by 10.50.138.72 with SMTP id qo8mr24656872igb.81.1453831706354; Tue, 26 Jan 2016 10:08:26 -0800 (PST) Sender: bsd-src@helfman.org Received: by 10.107.142.66 with HTTP; Tue, 26 Jan 2016 10:08:26 -0800 (PST) In-Reply-To: <20160126153932.GC46193@FreeBSD.org> References: <201601251910.u0PJAdeU003331@repo.freebsd.org> <20160126141038.GA46193@FreeBSD.org> <4C5F6D463ACD91B52D4AC5AF@ogg.in.absolight.net> <20160126153932.GC46193@FreeBSD.org> Date: Tue, 26 Jan 2016 10:08:26 -0800 X-Google-Sender-Auth: hUaxRd4WahHVq-zm9lp8UsuAXMk Message-ID: Subject: Re: svn commit: r407237 - head/mail/imaputils From: Jason Helfman To: Alexey Dokuchaev Cc: Mathieu Arnold , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Kurt Jaeger , "ports-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 18:08:27 -0000 On Tue, Jan 26, 2016 at 7:39 AM, Alexey Dokuchaev wrote: > On Tue, Jan 26, 2016 at 04:09:57PM +0100, Mathieu Arnold wrote: > > +--On 26 janvier 2016 14:10:38 +0000 Alexey Dokuchaev > > > wrote: > > | On Mon, Jan 25, 2016 at 07:10:39PM +0000, Kurt Jaeger wrote: > > |> New Revision: 407237 > > |> URL: https://svnweb.freebsd.org/changeset/ports/407237 > > |> > > |> Log: > > |> mail/imaputils: remove redundant GH_PROJECT entry > > |> > > |> PR: 206540 > > |> Submitted by: mat > > | > > | This commit has nothing to do with that PR, and that PR was not > submitted > > | by mat@. Please be more careful with attribution, it confuses people > when > > | done wrong. > > > > Well, the "submitted by" is not related to who submitted the PR, it is > > related to who submitted the change. For example, one person can create > a > > PR without a patch and the committer fixes it, then the "submitted by" is > > empty, or someone else adds the patch to the PR, then the "submitted by" > > contains the person that sent the patch. > > Right, there are few possible combinations like that; usually I try to give > attribution in a way that makes the most sense if read naturally (top to > bottom). For example, for the actuall patch submitted by foo, with a > related PR (submitted by someone else) it's probably better to put > "Submitted by" line first, and PR line after. Or clarify whose > contribution > is whose by putting it next to name/PR in parentheses or something. > > ./danfe > > I did put a PR in for this issue, which could possibly be leveraged and clear the commit confusion. The PR adds a "Reported by" to the FreeBSD template. These are problem reports, and I think it is appropriate to have that someone reported a problem report. If there is a submission associated with the report, it then is very clear that it was reported by one person, and another individual submitted a fix. I put this in awhile ago, and there was some discussion about it, however the PR has not yet been committed at this point. Whether or not this is a good solution, or there is something better, is another matter entirely. I have been using this in my commitlogs for sometime now, and have found it to be very handy, and have yet to find a case where it was confusing or misleading. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve