From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jan 8 02:03:51 2005 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBA5116A4CE; Sat, 8 Jan 2005 02:03:51 +0000 (GMT) Received: from vader.aacc.edu (vader.aacc.cc.md.us [12.167.138.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D47443D45; Sat, 8 Jan 2005 02:03:51 +0000 (GMT) (envelope-from fox@vader.aacc.cc.md.us) Received: from vader.aacc.edu (localhost [127.0.0.1]) by vader.aacc.edu (8.12.11/8.12.11) with ESMTP id j0822wsZ025771; Fri, 7 Jan 2005 21:02:58 -0500 Received: from localhost (fox@localhost)j0822vN8025768; Fri, 7 Jan 2005 21:02:58 -0500 X-Authentication-Warning: vader.aacc.edu: fox owned process doing -bs Date: Fri, 7 Jan 2005 21:02:57 -0500 (EST) From: fox@vader.aacc.cc.md.us X-X-Sender: fox@vader.aacc.edu To: Volker Stolz In-Reply-To: <20050107082334.GA42289@i2.informatik.rwth-aachen.de> Message-ID: References: <200501061748.j06HmgfF058433@www.freebsd.org> <20050107082334.GA42289@i2.informatik.rwth-aachen.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/75890: Port net/tkabber breaks "make index" under 4.8 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2005 02:03:51 -0000 On Fri, 7 Jan 2005, Volker Stolz wrote: > In gmane.os.freebsd.devel.ports.bugs, you wrote: >>> Description: >> 4.x make(1) doesn't understand -C before src/usr.bin/make/main.c 1.35.2.9 (RELENG_4_9). >> This causes "make index" in /usr/ports to fail, among other things. >> >> COMMENT= Tcl/Tk based jabber client >> >> -TCLLIBVER!= ${MAKE} -C ${.CURDIR}/../../devel/tcllib -V PORTVERSION >> +TCLLIBVER!= ${MAKE} -C ${.CURDIR}/../../devel/tcllib -V PORTVERSION 2>/dev/null \ >> + || (cd ${.CURDIR}/../../devel/tcllib; ${MAKE} -V PORTVERSION) > > Shouldn't it be sufficient to *always* use the latter construct? Hmm... I think it would be now, but it's not guaranteed to remain that way. The second operand of || may not do the same as the first in versions (current or future) of make that understand -C. Also, written this way, it makes it obvious it's a workaround until versions of FreeBSD with a make that doesn't grok -C go away. (meaning 4.8 and below) -- "I'd ask if you'd found the right sort of isolated wasteland for your citadel of dread yet, but that would be a silly question; you're in Utah, after all." --ESR to Darl McBride (Chief Excessive Ossifier of Squandered Clues Obstination), in http://www.catb.org/~esr/writings/mcbride.html