Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 May 2013 23:32:17 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@freebsd.org
Subject:   ports/179130: [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
Message-ID:  <20130530213226.EA690D64@hub.freebsd.org>
Resent-Message-ID: <201305302140.r4ULe0Q0063152@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179130
>Category:       ports
>Synopsis:       [PATCH] multimedia/vcdgear: Convert to OptionsNG, trim comment and docs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 30 21:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Tue Jan 29 15:02:50 EST 2013
>Description:

- Shorten header
- Trim comment
- Convert to OptionsNG
- Trim docs
- Remove pkg-plist

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130530202301-46110/

>Fix:

--- vcdgear-1.6d.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/Makefile ./Makefile
--- /usr/ports/multimedia/vcdgear/Makefile	2013-01-14 17:54:56.000000000 +0100
+++ ./Makefile	2013-05-30 23:29:41.000000000 +0200
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	vcdgear
-# Date created:	 	06 January 1999
-# Whom:			Chris Piazza <cpiazza@FreeBSD.org>
-#
+# Created by: Chris Piazza <cpiazza@FreeBSD.org>
 # $FreeBSD: head/multimedia/vcdgear/Makefile 300896 2012-07-14 13:54:48Z beat $
-#
 
 PORTNAME=	vcdgear
 PORTVERSION=	1.6d
@@ -11,11 +7,16 @@
 MASTER_SITES=	http://www.vcdgear.com/files/
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A tool to convert VCDs from cue/bin format to mpeg
+COMMENT=	Tool to convert VCDs from cue/bin format to mpeg
 
 ONLY_FOR_ARCHS=	alpha i386 amd64
 
+PLIST_FILES=	bin/${PORTNAME}
+
+PORTDOCS=	faq.txt manual.txt whatsnew.txt
+
 .include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 .if ${ARCH} == i386 || ${ARCH} == amd64
 DISTNAME=	${PORTNAME}16d_i386_freebsd42
@@ -27,12 +28,10 @@
 WRKSRC=		${WRKDIR}/vcdgear16
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/vcdgear
-.if !defined(NOPORTDOCS)
+	${INSTALL_PROGRAM} ${WRKSRC}/vcdgear16_static ${PREFIX}/bin/${PORTNAME}
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-.for file in faq.txt manual.txt whatsnew.txt
-	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.post.mk>
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/distinfo ./distinfo
--- /usr/ports/multimedia/vcdgear/distinfo	2013-01-14 17:54:56.000000000 +0100
+++ ./distinfo	2013-03-29 16:29:12.000000000 +0100
@@ -1,4 +1,2 @@
-SHA256 (vcdgear16d_alpha_freebsd41.tar.gz) = cedce8180bd7e4959aaa3b26d4e83d0804c156c94168a1ef7f0f7259f91159e8
-SIZE (vcdgear16d_alpha_freebsd41.tar.gz) = 121796
 SHA256 (vcdgear16d_i386_freebsd42.tar.gz) = c90cc63ff402ab6bcfc545d9b534bd3ce86954d8a5b2069554174073b73bf432
 SIZE (vcdgear16d_i386_freebsd42.tar.gz) = 98035
diff -ruN --exclude=CVS /usr/ports/multimedia/vcdgear/pkg-plist ./pkg-plist
--- /usr/ports/multimedia/vcdgear/pkg-plist	2013-01-14 17:54:56.000000000 +0100
+++ ./pkg-plist	1970-01-01 01:00:00.000000000 +0100
@@ -1,5 +0,0 @@
-bin/vcdgear
-%%PORTDOCS%%share/doc/vcdgear/faq.txt
-%%PORTDOCS%%share/doc/vcdgear/manual.txt
-%%PORTDOCS%%share/doc/vcdgear/whatsnew.txt
-%%PORTDOCS%%@dirrm share/doc/vcdgear
--- vcdgear-1.6d.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130530213226.EA690D64>