From owner-cvs-all  Wed Nov  6 18:33:59 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 675B537B401; Wed,  6 Nov 2002 18:33:57 -0800 (PST)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp [133.11.205.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A4A7D43E3B; Wed,  6 Nov 2002 18:33:56 -0800 (PST)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp [127.0.0.1])
	by is2.mh.itc.u-tokyo.ac.jp (Postfix) with ESMTP
	id EEDEB3780CE; Thu,  7 Nov 2002 11:33:50 +0900 (JST)
Received: from mailhosting.itc.u-tokyo.ac.jp (IDENT:mirapoint@mailhosting.itc.u-tokyo.ac.jp [133.11.205.3])
	by is2.mh.itc.u-tokyo.ac.jp (8.11.3/8.11.3) with ESMTP id gA72Xo021430;
	Thu, 7 Nov 2002 11:33:50 +0900
Received: from ett.sat.t.u-tokyo.ac.jp (nat.keisu.t.u-tokyo.ac.jp [133.11.68.2])
	by mailhosting.itc.u-tokyo.ac.jp (Mirapoint Messaging Server MOS 2.9.3.2)
	with ESMTP id AHH69982;
	Thu, 7 Nov 2002 11:33:49 +0900 (JST)
Date: Thu, 07 Nov 2002 11:33:49 +0900
Message-ID: <ybsu1iuhzw2.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h 
In-Reply-To: <2604.1036598903@critter.freebsd.dk>
References: <200211061550.gA6FoWQj062987@repoman.freebsd.org>
	<2604.1036598903@critter.freebsd.dk>
User-Agent: Wanderlust/2.11.0 (Wonderwall) REMI/1.14.3 (Matsudai)
 FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.4
 (patch 8) (Honest Recruiter) (i386--freebsd)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:
 #j7i14gu$jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oV
 uO^<vt/~051rCDM(`{rM~?{Okr,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

At Wed, 06 Nov 2002 17:08:23 +0100,
Poul-Henning Kamp wrote:
> 
> In message <200211061550.gA6FoWQj062987@repoman.freebsd.org>, Hidetoshi Shimoka
> wa writes:
> >simokawa    2002/11/06 07:50:32 PST
> >
> >  Modified files:
> >    sys/dev/nge          if_nge.c if_ngereg.h 
> >  Log:
> >  Add support for DEVICE_POLLING.
> >  
> >  PR: kern/44772
> >  Submitted by: Takashi Oono <takashi@yha.att.ne.jp>
> >  MFC after: 1 week
> >  
> >  Revision  Changes    Path
> >  1.36      +76 -0     src/sys/dev/nge/if_nge.c
> >  1.8       +3 -0      src/sys/dev/nge/if_ngereg.h
> 
> Hang on for a second:
> 
> This chip supports interrupt pacing so I would like to see
> some documentation for an improvement from DEVICE_POLLING over
> tuning the interrupt pacing in the chip, before we even think
> about MFC, much less let this commit stay in the tree.

I think interrupt pacing usually does good job too.

But still, I think there could be some cases device polling does
better job (ex. multiple busy NICs.) and it's a good thing
to give a option to users.

> What tests have been run ?  
> What are the numbers ?  (and please, include a standard deviation!)

I don't have any numbers by myself. I'm asking for the original author
whether he has.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message