From owner-freebsd-current Fri Jan 17 10:30:54 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C33337B401 for ; Fri, 17 Jan 2003 10:30:53 -0800 (PST) Received: from procyon.firepipe.net (procyon.firepipe.net [198.78.66.151]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13E2343F5B for ; Fri, 17 Jan 2003 10:30:53 -0800 (PST) (envelope-from will@csociety.org) Received: by procyon.firepipe.net (Postfix, from userid 1000) id A40702A009; Fri, 17 Jan 2003 10:26:10 -0800 (PST) Date: Fri, 17 Jan 2003 10:26:10 -0800 From: Will Andrews To: Joe Marcus Clarke Cc: freebsd-current@FreeBSD.ORG Subject: Re: VM_METER no longer defined? Message-ID: <20030117182610.GR30015@procyon.firepipe.net> Mail-Followup-To: Joe Marcus Clarke , freebsd-current@FreeBSD.ORG References: <3E284083.3030504@btc.adaptec.com> <1042826526.328.24.camel@gyros> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1042826526.328.24.camel@gyros> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jan 17, 2003 at 01:02:07PM -0500, Joe Marcus Clarke wrote: > It looks like Matt did this to fix vm.vmtotal. From sys/vm/vm_param.h: > > Make 'sysctl vm.vmtotal' work properly using updated patch from Hiten. > (the patch in the PR was stale). > > It looks to have been replaced by VM_TOTAL. I fixed libgtop[2] by > checking for VM_TOTAL, and using that instead of VM_METER. This seems > to work. Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard compatability rules: deprecate for one major version and remove in the second. I haven't seen any reason why this couldn't be added to vm/vm_param.h: #define VM_METER VM_TOTAL for compatability purposes. This change is way too sudden in an external API (if it's supposed to be internal, then protect it with an #ifdef _KERNEL already!). Regards, -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message