Date: Thu, 28 Feb 2019 16:53:50 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Ed Maste <emaste@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, stable@freebsd.org, Dimitry Andric <dim@freebsd.org> Subject: Re: FreeBSD 12.0 RELEASE i386 can not build a kernel? Message-ID: <201903010053.x210ro2G058632@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfoQM-rvzV3GxcKrKyZHyD77YwkKbnEOz%2BmWGaPRE4Mq1Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> On Thu, Feb 28, 2019 at 10:00 AM Rodney W. Grimes <
> freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
>
> > [ Charset UTF-8 unsupported, converting... ]
> > > On Thu, 28 Feb 2019 at 09:33, Rodney W. Grimes
> > > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> > > >
> > > > LD?=ld.lld in the right place(s)?
> > >
> > > Perhaps, I seem to recall some issue with that, but not the specifics.
> >
> > sys.mk already does a LD?=ld so by the time we try
> > to override it in the Makefile.i386 it is too late
> > as already defined.
> >
> > *sigh*
> >
>
> Yes, the problem is that ?= only works once. There's some gross things we
> can do, but they aren't worthwhile, imho.
>
> eg
>
> .if defined(KERNEL_LD_OVERRIDE)
> LD=${KERNEL_LD_OVERRIDE}
> .else
> LD=ld.lld
> .endif
>
> or other variations on that. We could do it without the .else clause and
> just add KERNEL_LD_OVERRIDE=ld.lld to GENERIC on i386 as a build-time
> override. This would give people a way out, but would violate POLA a little
> bit. Given the frequency of overriding LD=, it may be OK. People
> sophisticated enough to do that surely are sophisticated enough to read
> changes to the kernel config files. This wouldn't help everybody
> (especially those with custom kernel configs), but short of adding it to
> DEFAULTS, it's likely pushing the edge of how disruptive one can be in a
> stable branch.
>
> So there's a number of variations on this theme. I'm not convinced they are
> worthwhile for this issue because none are side-effect free, but it's
> certainly a solution space others can noodle through to see if they can
> find the "just so" mix of POLA and bug fixing.
I would be happy with expanding the error that is emitted by
pre.mk to add the text "You can fix this with LD=ld.lld make ..."
and an entry in UPDATING that specifically says for 12.0 on i386 you need...
> Warner
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903010053.x210ro2G058632>