Date: Fri, 10 May 2013 20:06:51 -0400 From: Mark Johnston <markj@freebsd.org> To: Glen Barber <gjb@FreeBSD.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r250479 - stable/8/usr.sbin/newsyslog Message-ID: <20130511000651.GA1759@gloom> In-Reply-To: <20130510234147.GC1651@glenbarber.us> References: <201305102056.r4AKu7h7047000@svn.freebsd.org> <20130510234147.GC1651@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 10, 2013 at 07:41:47PM -0400, Glen Barber wrote: > On Fri, May 10, 2013 at 08:56:07PM +0000, Mark Johnston wrote: > > Author: markj > > Date: Fri May 10 20:56:07 2013 > > New Revision: 250479 > > URL: http://svnweb.freebsd.org/changeset/base/250479 > > > > Log: > > MFC r248776: > > Fix interval-based rotations when the -t flag is used. In this case, find > > the most-recently archived logfile and use its mtime to determine whether > > or not to rotate, as in the non-timestamped case. > > > > Previously we would just try to use the mtime of <logfile>.0, which always > > results in a rotation since it generally doesn't exist in the -t case. > > > > Approved by: emaste > > > > Modified: > > stable/8/usr.sbin/newsyslog/newsyslog.c > > Directory Properties: > > stable/8/usr.sbin/newsyslog/ (props changed) > > > > I think this commit breaks stable/8 for at least mips and arm. > > http://tinderbox.freebsd.org/tinderbox-freebsd8-build-RELENG_8-mips-mips.full > > Glen > I'm very sorry about that. :( I've fixed the problem in r250489 and r250490.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130511000651.GA1759>