From owner-cvs-all Sun Feb 15 15:46:47 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA17857 for cvs-all-outgoing; Sun, 15 Feb 1998 15:46:47 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA17783; Sun, 15 Feb 1998 15:46:16 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id KAA19514; Mon, 16 Feb 1998 10:43:37 +1100 Date: Mon, 16 Feb 1998 10:43:37 +1100 From: Bruce Evans Message-Id: <199802152343.KAA19514@godzilla.zeta.org.au> To: gibbs@plutotech.com, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ccd ccd.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >>jkh 1998/02/15 00:28:28 PST >> >> Modified files: >> sys/dev/ccd ccd.c >> Log: >> Revert part of my previous patch - I don't see the *need* >> to call splbio() from within an interrupt handler here. :-) > >Probably because it is not a real interrupt handler and is not >always called from an splbio() interrupt context. But it was always called from an splbio() context - it is only called from cciodone() which begins with splbio() and finishes with splx(). I think this spl pair is bogus too. cciodone() is only called via the b_iodone callback, and I think b_iodone is only called from biodone() where it is always called in an splbio() context. The call in ccdintr() was even more bogus: - the result was assigned to a nonexistent variable. - there was no matching splx() (this wouldn't have mattered because of two unnecessary layers of splbio()s). "Reverting" part of the previous patch introduced a style bug by removing an empty line. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message