Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Dec 2006 14:53:11 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Pawel Jakub Dawidek <pjd@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 111284 for review
Message-ID:  <200612081453.12227.jhb@freebsd.org>
In-Reply-To: <200612081207.kB8C74hR038904@repoman.freebsd.org>
References:  <200612081207.kB8C74hR038904@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 08 December 2006 07:07, Pawel Jakub Dawidek wrote:
> http://perforce.freebsd.org/chv.cgi?CH=111284
> 
> Change 111284 by pjd@pjd_anger on 2006/12/08 12:06:23
> 
> 	We need to pass static buffer to device_set_desc().

Or use device_set_desc_copy().  This change below won't work if you ever have 
2 padlock devices with different descriptions.

> Affected files ...
> 
> .. //depot/projects/crypto/sys/crypto/via/padlock.c#3 edit
> 
> Differences ...
> 
> ==== //depot/projects/crypto/sys/crypto/via/padlock.c#3 (text+ko) ====
> 
> @@ -80,7 +80,7 @@
>  static int
>  padlock_probe(device_t dev)
>  {
> -	char capp[256];
> +	static char capp[256];
>  
>  #if defined(__i386__) && !defined(PC98)
>  	/* If there is no AES support, we has nothing to do here. */
> 

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612081453.12227.jhb>