From owner-freebsd-current@FreeBSD.ORG  Wed Dec  3 07:04:44 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A061A16A4CE
	for <current@FreeBSD.ORG>; Wed,  3 Dec 2003 07:04:44 -0800 (PST)
Received: from chaos.fxp.org (chaos.fxp.org [209.251.159.150])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ACE8243FBF
	for <current@FreeBSD.ORG>; Wed,  3 Dec 2003 07:04:43 -0800 (PST)
	(envelope-from jedgar@fxp.org)
Received: by chaos.fxp.org (Postfix, from userid 1000)
	id E73BD40C; Wed,  3 Dec 2003 10:04:42 -0500 (EST)
Date: Wed, 3 Dec 2003 10:04:42 -0500
From: Chris Faulhaber <jedgar@fxp.org>
To: Soren Schmidt <sos@spider.deepcore.dk>
Message-ID: <20031203150442.GA30637@chaos.fxp.org>
References: <20031201190045.GE57659@chaos.fxp.org>
	<200312030855.hB38tuED056388@spider.deepcore.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200312030855.hB38tuED056388@spider.deepcore.dk>
X-Mailer: socket()
cc: NAKAJI Hiroyuki <nakaji@jp.freebsd.org>
cc: current@FreeBSD.ORG
Subject: Re: [ATAng?] ad1 disappeared again
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Dec 2003 15:04:44 -0000

On Wed, Dec 03, 2003 at 09:55:56AM +0100, Soren Schmidt wrote:
> It seems Chris Faulhaber wrote:
> > I have been seeing the same issue since August with a different,
> > but similiar, set of drives:
> > 
> > ad0: 57241MB <ST360015A> [116301/16/63] at ata0-master UDMA100
> > ad1: 57241MB <ST360015A> [116301/16/63] at ata0-slave UDMA100
> > 
> > Under -CURRENT only the first drive is seen; RELENG_4 still works
> > fine.
> 
> Could you try this patch and get back to me with the result please:
> 

Works for me:

GEOM: create disk ad0 dp=0xc6972c60
ad0: 57241MB <ST360015A> [116301/16/63] at ata0-master UDMA100
GEOM: create disk ad1 dp=0xc6972b60
ad1: 57241MB <ST360015A> [116301/16/63] at ata0-slave UDMA100

> Index: ata-lowlevel.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
> retrieving revision 1.23
> diff -u -r1.23 ata-lowlevel.c
> --- ata-lowlevel.c      2 Nov 2003 22:04:53 -0000       1.23
> +++ ata-lowlevel.c      3 Dec 2003 07:50:44 -0000
> @@ -575,7 +575,7 @@
>                 }
>             }
>         }
> -       if (stat1 & ATA_S_BUSY) {
> +       if (!((mask == 0x03) && (stat0 & ATA_S_BUSY)) && (stat1 & ATA_S_BUSY)) {
>             ATA_IDX_OUTB(ch, ATA_DRIVE, ATA_D_IBM | ATA_SLAVE);
>             DELAY(10);
> 
> -S?ren
>                        .. but it works under windows!!
> 

-- 
Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
--------------------------------------------------------
FreeBSD: The Power To Serve   -   http://www.FreeBSD.org