From owner-svn-src-all@freebsd.org Wed Jul 8 22:28:57 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1316F996A41 for ; Wed, 8 Jul 2015 22:28:57 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm43-vm10.bullet.mail.bf1.yahoo.com (nm43-vm10.bullet.mail.bf1.yahoo.com [216.109.114.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B48C0189E for ; Wed, 8 Jul 2015 22:28:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1436394154; bh=drA0bI2Hae8LrIRRRBiNAusivhRIWAECrxpk+gh8nBg=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=tfoXUhacJT/FTKGehsbIMLPQ6HWsXquKNA2VzbxNBnDo3r9XK7J9LeJAeuHqEEK56ZIk2m6ve8y3Dvr9YHlF98wAkgMmMeCvORh3M9i9Y3/ku8WYlRtSQoj2JoFJAU8/GcmJlPwnPfl0xH/zJyCR/sLR9LyJN2II3Plw4wQ6r3tMakh+n3DWwOYEiECQEUlioXYNvLGvJVwnV8Kzh3wc4Oo6V2gXJqwVt35jvwiN5s0F+9hzewzrj+TujKwn3jNK+TxJ1LJH09we0PIjuu6z8LE53U3Gvhn1uReu7vgNoWxOBzL5hdJFT30h5ZIYcBXm9rq3gB94T1FSu9WWwxzJ6w== Received: from [98.139.215.141] by nm43.bullet.mail.bf1.yahoo.com with NNFMP; 08 Jul 2015 22:22:34 -0000 Received: from [98.139.211.194] by tm12.bullet.mail.bf1.yahoo.com with NNFMP; 08 Jul 2015 22:22:34 -0000 Received: from [127.0.0.1] by smtp203.mail.bf1.yahoo.com with NNFMP; 08 Jul 2015 22:22:34 -0000 X-Yahoo-Newman-Id: 566386.20309.bm@smtp203.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: H_UQFYEVM1nY3JfvmKpZgbqjDVaH0VBNFSqPmpb1vfOwKB_ l8dX.f3AUl1MhylXRIDgoQkHtb62YTVFkKEGq9O6Q9InoMymj9jV9qkGyzuN QDifKswvgW47PVQNn44nC5PXJQQQ7jOyTvwQ7v3VySMQ1kjCW79nSS0IAVQL KoS_85991P6JCjvhgav_Ts1X8pO3dRYBVOVsAlGorGVhXSLxZ6RojaEFMrS8 oyjEigNXdt3Q6aV9atiwcR274e2zEVxVOqNaI6Xd9ZErqyKOlLUJBAp2DkXk O.UQNk_.Tb_bC2vqWU59_DT.96kPVZKCj5CyzZtiR.I86wcki5.1uExcP1Kk Kzo9k3G7v6mtGgqS001uHmHnUedONgilQV85aBa06_2ZBo3.NnNSDH.gdVIq C_sI_pusEZlcnHGL2gCy.pxaKxaiF0h2NIg0SHFq7MwIfHkah97P9BNol6tO 8Ie3KxWL1BKMJQVlYeXzXpOdxKobZ6PE3UxYeapwL3mSk4lrWnLlnvM4A8dB 9iSap0A8DtSoTa70MWRV6C.7NBdcuK6UY X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <559DA2AE.2090202@FreeBSD.org> Date: Wed, 08 Jul 2015 17:22:38 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Adrian Chadd CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r285284 - head/lib/liblzma References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:28:57 -0000 On 07/08/15 17:04, Adrian Chadd wrote: > Is there a blessed way to see whether the compiler we're using is an > external compiler, or an internal one? No blessed way: you still have to determine the version of the external compiler for most purposes anyways. The internal compiler (even clang) always reports itself as gcc 4.2. > eg, the version check isn't enough - it's just a number. how do I know > if it's freebsd clang versus upstream clang? > (Or in my instance, freebsd-gcc versus upstream-gcc.) If the compiler reports itself as gcc >= 4.3 it is surely an external compiler. The tricky part is that our internal gcc supports some gcc 4.3 flags and Apple extensions (blocks), but those are not causing a problem AFAICT. Pedro. > > -a > > > On 8 July 2015 at 14:09, Pedro Giffuni wrote: >> >> On 07/08/15 13:36, Luigi Rizzo wrote: >>> Author: luigi >>> Date: Wed Jul 8 18:36:37 2015 >>> New Revision: 285284 >>> URL: https://svnweb.freebsd.org/changeset/base/285284 >>> >>> Log: >>> only enable immintrin when clang is used. The base gcc does not support >>> it. >>> Reviewed by: delphij >>> >>> Modified: >>> head/lib/liblzma/config.h >>> >>> Modified: head/lib/liblzma/config.h >>> >>> ============================================================================== >>> --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 (r285283) >>> +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 (r285284) >>> @@ -150,7 +150,8 @@ >>> #define HAVE_ICONV 1 >>> /* Define to 1 if you have the header file. */ >>> -#if defined(__FreeBSD__) && defined(__amd64__) >>> +/* FreeBSD - only with clang because the base gcc does not support it */ >>> +#if defined(__clang__) && defined(__FreeBSD__) && defined(__amd64__) >>> #define HAVE_IMMINTRIN_H 1 >>> #endif >>> >> FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) >> effect when building with an external gcc. >> >> Pedro. >>