From owner-svn-src-head@freebsd.org Sat Sep 19 23:18:58 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B79623F213E; Sat, 19 Sep 2020 23:18:58 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670079.outbound.protection.outlook.com [40.107.67.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bv68f2kwpz4dNK; Sat, 19 Sep 2020 23:18:58 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAUmtlwAcApFTtDUANR8/A2+oBlAbd243S3Q4daXKs7o9Nao2mdsL6rSg0arRoVPSKaRL+QZKv2fppq6IscGUZ6j57xwacjniv2eZ4hJy1Ys8amZ4qyhrXEU8xcYYZZikySMj0UcounrG1xPK0WFXPMxL+F4sO344BFB2GX9kmEjp829D6oAEjuwdYi+KdqHBUnKeyTSWbbByyPII/jNCJviGmkCEW/bBz3Bn82PVPuJW4O56Qvtio5FjYWdyRY0E68Z0+MDR77SZGzXVwSClHoeZgryleDS5joF3h1Fyuljo5WTR3sNtyVl/bcaiq0VGL7BM/iCRbPv1ZPVlKy20Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2YLSUg46x0bcKcjVXjgwq0V8KzfTLzN/NQ/K/Ft4Pqo=; b=AV20UyDZerfaLCfhK1nJ6ytK2WoMtYvUxDBaWDvAf54EWgeYDoajtnDVJeHPcDCMIv63P8yT+HZgPNm8boOwf9nqH5RbX1W4INKdBvpVwIgQgAanf0CGFI7vUdiAl35A9ECq3CD7AzkzpXxSUxTi06FbcZQ+0NXzXSdlWSUqksp8vNT60XsZdGi+m9lYEzmpBknxl2TkZRQClD4BapOHSA9upWUftCNKxiUI52qf/uEMlRrTGyfChxyPIj+HbvCEexNhSxgD4bbKUnajiaBepzgRv78LxOSsFGzDdhXdglF8gNu62JcKPw7xZCbIUNa0sPEX1Yckbjhz+sMZ8oVWmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2YLSUg46x0bcKcjVXjgwq0V8KzfTLzN/NQ/K/Ft4Pqo=; b=ev29qWRAJFvzEJjHOvgTDaNm4Fll1STPE9oUI4K+M/lob1Kif23pYdOdJmZUoo7aVpmrAc9Zfgnr+TgIz/Gb9u/TJHmwMfrD3pA6uuZgcv03J1Y0pU3pGU50KsHgIvWphnOTDWb5sHm3BDv4TuoMyHMxde0LiLGwLNTwhjIwiLqFLZrFLja9sYyOTvMmLc28isi69tfbhiRdp/21Rwxe16gH0MgvaUwLYvIs0PwVutO2cIJmBXQelQ2zESwiP2kW7GVf1QWRF1+qfLs4/aa2M6geALbtwH3Qf3Y8314eEyFB0+NZmYTyfyYV476wPTtsG9WOk2lwqwOMpGAzN2VSdQ== Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:24::27) by YTBPR01MB2895.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:17::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sat, 19 Sep 2020 23:18:56 +0000 Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20]) by YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20%6]) with mapi id 15.20.3391.014; Sat, 19 Sep 2020 23:18:56 +0000 From: Rick Macklem To: Alan Somers CC: Konstantin Belousov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r365643 - head/bin/cp Thread-Topic: svn commit: r365643 - head/bin/cp Thread-Index: AQHWiH0X8pBOJ1Dd2EKX5zw9++b1Talj+C+AgAABEqiADFMkAIAAVZ6L Date: Sat, 19 Sep 2020 23:18:56 +0000 Message-ID: References: <202009112049.08BKnavL032212@repo.freebsd.org> <20200911214327.GY94807@kib.kiev.ua> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57d7a48d-7828-413f-0a2c-08d85cf261b5 x-ms-traffictypediagnostic: YTBPR01MB2895: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YPB7kw8QL9woeCq4x7tf9cj1y4WNLMxyjB5U99/QDsrsug91Zht8J3a/vCughKGlzxm9GaWG1onBAzHCTp8ps2iDJ6kpTHieMythjEIl1b5K4pAwtKAUBK5t+TRCVPQOWe3EeFrVXDB51jL+1XZUn8x3eCw8jn42aVT5YRRuKvcCDVPnekf+d8aJLSM4NXdfJg+YJ4ppozrmZQXebCJchk5Gs3XBVVrF2YEzHH/9K+4VT7KV+pFcl84fappdvAZHOCX2uhLdcVrssjteXUL1Q1DThNr4anJMqD7ECBnygX54KpXXbRGPtQq+8uLYQg1UNYzmLLYDIPORgUu264NAxTTw9S2gMOuc4nlPjCN8G5+mYROotbmoHCV+YwYEtkZpOVw/kgIJAOfawyQG8Rc5tQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(39850400004)(396003)(366004)(136003)(346002)(376002)(54906003)(786003)(316002)(7696005)(86362001)(91956017)(8676002)(33656002)(76116006)(55016002)(8936002)(2906002)(9686003)(52536014)(5660300002)(186003)(966005)(478600001)(66946007)(6916009)(6506007)(64756008)(66446008)(4326008)(66556008)(71200400001)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PbWzf9n7O1YJc5CxfsVLEYOHtJaxO4hSVg9m61CSimx7HFNlD9b9b4Z0UZfybBZk38VnRmCr7qj6PuaUA7d44Jk/lkZDeHDK5ReF6dbCYIy+nQQnf2kQii8yvDVZnQUcewH5m2xH8AYUse8TYEVa3xypvn4+MgJT9pCBse8bmXbBf6RX7kHk8Qj7uLrl2rvlqfLIirAxuNTiXmOnwtPH0emtAV4AZ6Xf4RJp6v6eTOnZahmO8MrXwjlkks3m8kM0sDtne23yY91c3zKASMMzf8XbeFzDrmGTZ0b2T185+K7yy2GYi+YJXuct+JYpsNi5zW/S4Fv8XZE5BAt11x5PDce9kjbdNCgFLeQtI4fnugtbGzZzw9loN0tmu3+mXgDamcbJoLHTdxJ+KC3PdEpiGisWp+HbDugwEllD9wAO9VwCItm7uO/JCFhN4W1+Psdnn3lVDQCFPKQhFpSmbKNxWPWphJPkyuQblkelHjDZ+aqZlcI+O+QY+h197fgInUqY3alj30VJCA3T/RhHi/VFgAErZ2fnSUCFtDoWDyMUEn4WcpqzaIG+7vFEpRF4iYDDBEVX9uTlOPgvJYd8obA+YMZLe3c8QBqP0+QHENYn0AgCPNzaakh6zotG1F+0jbzuZPxc56tdGsTOPbsff3/PyNzGoUuXpJKLTzEUhV91xPVmI+rX9TRLnG9aAEQU+SPbFGk+b0EAGUWoW16nBZaSRw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 57d7a48d-7828-413f-0a2c-08d85cf261b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2020 23:18:56.2731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mpwUkpCDaAx4aZ4XzzoCAQjUjp0Ew96x0dY1Oj8/yOEyk5uFiVz0RhUOIvKeV9qfGuGvE8KNFoOcjIEp+E0vww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB2895 X-Rspamd-Queue-Id: 4Bv68f2kwpz4dNK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2020 23:18:58 -0000 Alan Somers wrote:=0A= >On Fri, Sep 11, 2020 at 3:52 PM Rick Macklem > wrote:=0A= >Konstantin Belousov wrote:=0A= >>On Fri, Sep 11, 2020 at 08:49:36PM +0000, Alan Somers wrote:=0A= >>> Author: asomers=0A= >>> Date: Fri Sep 11 20:49:36 2020=0A= >>> New Revision: 365643=0A= >>> URL: https://svnweb.freebsd.org/changeset/base/365643=0A= >>>=0A= >>> Log:=0A= >>> cp: fall back to read/write if copy_file_range fails=0A= >>>=0A= >>> Even though copy_file_range has a file-system agnostic version, it st= ill=0A= >>> fails on devfs (perhaps because the file descriptor is non-seekable?)= In=0A= >>> that case, fallback to old-fashioned read/write. Fixes=0A= >>> "cp /dev/null /tmp/null"=0A= >>=0A= >>Devices are seekable.=0A= >>=0A= >>The reason for EINVAL is that vn_copy_file_range() checks that both in an= d out=0A= >>vnodes are VREG. For devfs, they are VCHR.=0A= >=0A= >I coded the syscall to the Linux man page, which states that EINVAL is ret= urned=0A= >if either fd does not refer to a regular file.=0A= >Having said that, I do not recall testing the VCHR case under Linux. (ie. = It might=0A= >actually work and the man page turns out to be incorrect?)=0A= >=0A= >I will test this case under Linux when I get home next week, rick=0A= I'll admit I haven't tested this in Linux to see if they do return EINVAL.= =0A= =0A= >Since there's no standard, I think it's fine for us to support devfs if po= ssible.=0A= 1 - I think this is a good question for a mailing list like freebsd-current= @.=0A= 2 - I see Linux as the de-facto standard these days and consider POSIX no= =0A= longer relevant, but that's just mho.=0A= 3 - For NFSv4.2, the Copy operation will fail for non-regular files, so if = you=0A= do this, you will need to handle the fall-back to using the generic c= ode.=0A= (Should be doable, but you need to be aware of this case.)=0A= =0A= Having said the above, it is up to the "collective" and not me and, as such= ,=0A= I suggest #1, to see whether others think doing a non-Linux compatible=0A= version makes sense for FreeBSD?=0A= =0A= rick=0A=