From owner-freebsd-ports  Fri Aug 10 20:10: 9 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id C24B937B405
	for <freebsd-ports@hub.freebsd.org>; Fri, 10 Aug 2001 20:10:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7B3A1k85887;
	Fri, 10 Aug 2001 20:10:01 -0700 (PDT)
	(envelope-from gnats)
Received: from mail1.realtime.net (mail1.realtime.net [205.238.128.217])
	by hub.freebsd.org (Postfix) with SMTP id 8115D37B403
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 10 Aug 2001 20:02:49 -0700 (PDT)
	(envelope-from jdn@bga.com)
Received: (qmail 15762 invoked from network); 11 Aug 2001 03:02:47 -0000
Received: from max5-101.ip.realtime.net (HELO localhost) (205.238.178.101)
  by mail1.realtime.net with SMTP; 11 Aug 2001 03:02:47 -0000
Received: by localhost (Postfix, from userid 1000)
	id B028E20379; Fri, 10 Aug 2001 22:00:28 -0500 (CDT)
Message-Id: <20010811030028.B028E20379@localhost>
Date: Fri, 10 Aug 2001 22:00:28 -0500 (CDT)
From: Jay Nelson <jdn@bga.com>
Reply-To: Jay Nelson <jdn@bga.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: ports/29616: ports/net/generic-nqs loaddaemon does not report correct load
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         29616
>Category:       ports
>Synopsis:       ports/net/generic-nqs loaddaemon does not report correct load
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 10 20:10:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Jay Nelson
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
private
>Environment:
System: FreeBSD localhost 4.3-STABLE FreeBSD 4.3-STABLE #0: Sun Jul 22 10:16:32 CDT 2001 jdn@localhost:/usr/src/sys/compile/ACP i386

>Description:
	The defines in loaddaemon.c of the generic-nqs port do not
select appropriate behavior and defaults to returning a load of
999.99.  Consequently, dynamic load balancing will not function
properly.

>How-To-Repeat:
	Execute 'qmgr set debug 3' and observe logs.
>Fix:

--- Source-Tree/loaddaemon/all-systems/loaddaemon.c.orig	Thu Aug  2 01:18:37 2001
+++ Source-Tree/loaddaemon/all-systems/loaddaemon.c	Fri Aug  3 16:59:53 2001
@@ -539,6 +539,20 @@
 }
 #endif  /* HPUX */
 #if   IS_DECOSF | IS_BSD
+#if BSD4_4
+static
+void calcloadavg(double load[3])
+{
+    double avenrun[3];
+    int i;
+    if (getloadavg(avenrun, sizeof(avenrun) / sizeof(avenrun[0]))) {
+        printf("getloadavg goofed\n");
+    }
+    for (i = 0; i < 3; i++) {
+        load[i] = avenrun[i];
+    }
+}
+#else
 struct  nlist nl[] = {
 #define unixpath "/vmunix"
         { "_avenrun" },
@@ -570,6 +584,7 @@
     for (i = 0; i < 3; i++)
         load[i] = ((double) avenrun[i]) / (double) 1024.;
 }
+#endif	 /* BSD4_4 */
 #endif   /* DECOSF or Sun (BSD43) */
 
 #if IS_SOLARIS
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message