Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Sep 2017 14:04:34 +0200
From:      Christian Weisgerber <naddy@mips.inka.de>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r449357 - in head/net-p2p/mktorrent: . files
Message-ID:  <20170907120434.GA25166@lorvorc.mips.inka.de>
In-Reply-To: <20170907093407.GA7480@FreeBSD.org>
References:  <201709061910.v86JA8Rd002544@repo.freebsd.org> <20170907093407.GA7480@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev:

> > ...
> > -MASTER_SITES=	SF
> > +MASTER_SITES=	https://github.com/Rudde/mktorrent/archive/
> > +DISTNAME=	v${PORTVERSION}
> > +DIST_SUBDIR=	${PORTNAME}
> 
> Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these
> DIST_SUBDIR dances?

I don't know which scheme is preferable.  The Porter's Handbook
section on USE_GITHUB starts with "If the distribution file comes
from a specific commit or tag on GitHub for which there is no
officially released file, [...]".  But here we have an officially
released if awkwardly named distfile.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170907120434.GA25166>