From owner-svn-ports-all@freebsd.org Thu Sep 7 12:05:11 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19DF8E1B2C2; Thu, 7 Sep 2017 12:05:11 +0000 (UTC) (envelope-from naddy@mips.inka.de) Received: from mail.inka.de (quechua.inka.de [IPv6:2a04:c9c7:0:1073:217:a4ff:fe3b:e77c]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA9AD821CC; Thu, 7 Sep 2017 12:05:09 +0000 (UTC) (envelope-from naddy@mips.inka.de) Received: from mips.inka.de (naddy@[127.0.0.1]) by mail.inka.de with uucp (rmailwrap 0.5) id 1dpvYQ-0005gx-BN; Thu, 07 Sep 2017 14:05:06 +0200 Received: from lorvorc.mips.inka.de (localhost [127.0.0.1]) by lorvorc.mips.inka.de (8.15.2/8.15.2) with ESMTP id v87C4Y7W025347; Thu, 7 Sep 2017 14:04:34 +0200 (CEST) (envelope-from naddy@lorvorc.mips.inka.de) Received: (from naddy@localhost) by lorvorc.mips.inka.de (8.15.2/8.15.2/Submit) id v87C4Y6e025346; Thu, 7 Sep 2017 14:04:34 +0200 (CEST) (envelope-from naddy) Date: Thu, 7 Sep 2017 14:04:34 +0200 From: Christian Weisgerber To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449357 - in head/net-p2p/mktorrent: . files Message-ID: <20170907120434.GA25166@lorvorc.mips.inka.de> References: <201709061910.v86JA8Rd002544@repo.freebsd.org> <20170907093407.GA7480@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170907093407.GA7480@FreeBSD.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 12:05:11 -0000 Alexey Dokuchaev: > > ... > > -MASTER_SITES= SF > > +MASTER_SITES= https://github.com/Rudde/mktorrent/archive/ > > +DISTNAME= v${PORTVERSION} > > +DIST_SUBDIR= ${PORTNAME} > > Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these > DIST_SUBDIR dances? I don't know which scheme is preferable. The Porter's Handbook section on USE_GITHUB starts with "If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file, [...]". But here we have an officially released if awkwardly named distfile. -- Christian "naddy" Weisgerber naddy@mips.inka.de