From owner-freebsd-ports Fri Jan 11 10:10: 9 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id D9B0637B417 for ; Fri, 11 Jan 2002 10:10:00 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g0BIA0X18535; Fri, 11 Jan 2002 10:10:00 -0800 (PST) (envelope-from gnats) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 88E7C37B400 for ; Fri, 11 Jan 2002 10:08:41 -0800 (PST) Received: (from nobody@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g0BI8f518411; Fri, 11 Jan 2002 10:08:41 -0800 (PST) (envelope-from nobody) Message-Id: <200201111808.g0BI8f518411@freefall.freebsd.org> Date: Fri, 11 Jan 2002 10:08:41 -0800 (PST) From: "George W. Dinolt" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-1.0 Subject: ports/33786: port wxgtk-devel depends on libiconv, -liconv not included in wxgtk-config Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 33786 >Category: ports >Synopsis: port wxgtk-devel depends on libiconv, -liconv not included in wxgtk-config >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 11 10:10:00 PST 2002 >Closed-Date: >Last-Modified: >Originator: George W. Dinolt >Release: 4.5-PRERELEASE #2 >Organization: >Environment: FreeBSD dinolt1.bingdrive.org 4.5-PRERELEASE FreeBSD 4.5-PRERELEASE #2: Sat Jan 5 09:01:47 PST 2002 root@dinolt1.bingdrive.org:/tmp/usr-4/usr/src/sys/DINOLT1 i386 >Description: libwx_gtk built from the x11-toolkits/wxgtk-devel port references iconv, iconv_open and iconv_close. One can resolve these symbols using -liconv from the libiconv port. Currently wxgtk-devel does not seem to depend on libiconv (from converters) nor does wxgtk-config include -liconv, which would help build programs know of the dependency. >How-To-Repeat: Build the the port x11-toolkits/wxgtk-devel (do not clean), cd to /usr/ports/x11-toolkits/wxgtk-devel/work/wxGTK-2.3.1/samples/dialogs (or wherever) try gmake in that directory. The undefined references are given. This works on a 4.5-PRERELEASE system. I don't know what happens on a -CURRENT system. >Fix: The "easy" fix is to add converters/libiconv to the BUILD_DEPENDS in the wxgtk-devel Makefile (to make the dependency explicit in the build process) and to add -liconv to the EXTRA_LIBS in configure. There is probably a much better way to fix the configure script which would make it depend on whether iconv is found automagically or not. One could update the patch-configure file by adding the following lines in the appropriate place to ensure that -liconv is added. @@ -15783,7 +15763,7 @@ GUILIBS="$GUI_TK_LIBRARY $TOOLKIT_LINK" OPENGL_LIBS="$OPENGL_LINK" -EXTRA_LIBS="$LIBS $POSIX4_LINK $INET_LINK $WCHAR_LINK $THREADS_LINK $DMALLOC_LINK $DL_LINK $ZLIB_LINK -lm" +EXTRA_LIBS="$LIBS $POSIX4_LINK $INET_LINK $WCHAR_LINK $THREADS_LINK $DMALLOC_LINK $DL_LINK $ZLIB_LINK -liconv -lm" if test "$USE_MAC" = 1 ; then EXTRA_LIBS="$EXTRA_LIBS -framework Carbon -framework System" fi >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message