From owner-cvs-src Sat Feb 22 6:47:14 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA01A37B401; Sat, 22 Feb 2003 06:47:12 -0800 (PST) Received: from tesla.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD99E43FCB; Sat, 22 Feb 2003 06:47:11 -0800 (PST) (envelope-from bmilekic@unixdaemons.com) Received: (from bmilekic@localhost) by tesla.distributel.net (8.11.6/8.11.6) id h1MEkSQ85065; Sat, 22 Feb 2003 09:46:28 -0500 (EST) (envelope-from bmilekic@unixdaemons.com) Date: Sat, 22 Feb 2003 09:46:28 -0500 From: Bosko Milekic To: Bosko Milekic Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20030222094628.A85041@unixdaemons.com> References: <200302221446.h1MEkVWF057648@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200302221446.h1MEkVWF057648@repoman.freebsd.org>; from bmilekic@FreeBSD.org on Sat, Feb 22, 2003 at 06:46:31AM -0800 Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Feb 22, 2003 at 06:46:31AM -0800, Bosko Milekic wrote: > bmilekic 2003/02/22 06:46:31 PST > > Modified files: > sys/pci if_xl.c > Log: > Make xl use m_getcl() to allocate an mbuf and a cluster in one shot, > as opposed to one after the other. This is faster in both -CURRENT > and -STABLE. Additionally, there is less code duplication for > error-checking. > > One thing to note is that this code seems to return(1) when no buffers > are available; perhaps ENOBUFS should be the correct return value? > > Partially submitted & tested by: Hiten Pandya > MFC after: 1 week > > Revision Changes Path > 1.130 +5 -19 src/sys/pci/if_xl.c By the way, do the "MFC after" auto-emails work? Because if not I fear I'm going to forget to MFC all of this stuff. -- Bosko Milekic * bmilekic@unixdaemons.com * bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message