Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Nov 2002 19:12:33 -0800
From:      Kris Kennaway <kris@obsecurity.org>
To:        Eric Melville <eric@FreeBSD.org>
Cc:        Adam Weinberger <adamw@FreeBSD.org>, Kris Kennaway <kris@obsecurity.org>, Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: ports/textproc Makefile
Message-ID:  <20021107031232.GA18646@rot13.obsecurity.org>
In-Reply-To: <20021106190506.B72056@FreeBSD.org>
References:  <200211062255.gA6MtPuQ031772@repoman.freebsd.org> <20021106230310.GP197@vectors.cx> <20021106231336.GA17722@rot13.obsecurity.org> <20021106231718.GR197@vectors.cx> <20021106190506.B72056@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 06, 2002 at 07:05:06PM -0800, Eric Melville wrote:
> > > See the email I just sent to ports@.  It looks like there's a quoting
> > > bug in bsd.port.mk (it is causing INDEX builds to fail when
> > > PORTCOMMENT contain metacharacters).  Quoting the metacharacters stops
> > > the INDEX build breaking, but they show up quoted in INDEX because
> > > that instance of PORTCOMMENT is correctly quoted in bsd.port.mk.
> > 
> > Does this need to be backed out?
> 
> The problem should only show up in comments that contain a ' character, or
> perhaps characters that I haven't actually seen in any existing comments.

'+' is another very common one (e.g. in "C++").

I'm testing fenner's patch at the moment.

Kris

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021107031232.GA18646>