From owner-cvs-all Wed Nov 6 19:11:15 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 731A237B401; Wed, 6 Nov 2002 19:11:14 -0800 (PST) Received: from obsecurity.dyndns.org (adsl-63-207-60-146.dsl.lsan03.pacbell.net [63.207.60.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id A20C343E4A; Wed, 6 Nov 2002 19:11:13 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 3832566C4E; Wed, 6 Nov 2002 19:11:13 -0800 (PST) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id BCA48FB8; Wed, 6 Nov 2002 19:12:33 -0800 (PST) Date: Wed, 6 Nov 2002 19:12:33 -0800 From: Kris Kennaway To: Eric Melville Cc: Adam Weinberger , Kris Kennaway , Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/textproc Makefile Message-ID: <20021107031232.GA18646@rot13.obsecurity.org> References: <200211062255.gA6MtPuQ031772@repoman.freebsd.org> <20021106230310.GP197@vectors.cx> <20021106231336.GA17722@rot13.obsecurity.org> <20021106231718.GR197@vectors.cx> <20021106190506.B72056@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021106190506.B72056@FreeBSD.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Nov 06, 2002 at 07:05:06PM -0800, Eric Melville wrote: > > > See the email I just sent to ports@. It looks like there's a quoting > > > bug in bsd.port.mk (it is causing INDEX builds to fail when > > > PORTCOMMENT contain metacharacters). Quoting the metacharacters stops > > > the INDEX build breaking, but they show up quoted in INDEX because > > > that instance of PORTCOMMENT is correctly quoted in bsd.port.mk. > > > > Does this need to be backed out? > > The problem should only show up in comments that contain a ' character, or > perhaps characters that I haven't actually seen in any existing comments. '+' is another very common one (e.g. in "C++"). I'm testing fenner's patch at the moment. Kris To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message