Date: Tue, 3 May 2016 13:38:51 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298665 - head/sys/dev/aacraid Message-ID: <CAG6CVpXXKFwtV0CvjLXA_8mnkP1tCz9ZNf_%2BUpiZc%2BUAAGPyoA@mail.gmail.com> In-Reply-To: <A26C4B8A-DD67-4F57-9E26-3DEADE7C82F1@bsdimp.com> References: <201604262059.u3QKxLDl045059@repo.freebsd.org> <CAPQ4ffvro_5bV_OdH=OLBN8o1Ui%2BvCgi7kBbHjwnoMTAtbo%2B%2BQ@mail.gmail.com> <CAG6CVpWz6phJMzXoZARxUKQg7D1sV3xvdyui8tEftO4eJK1zJg@mail.gmail.com> <A26C4B8A-DD67-4F57-9E26-3DEADE7C82F1@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 3, 2016 at 1:29 PM, Warner Losh <imp@bsdimp.com> wrote: > >> On May 3, 2016, at 1:44 PM, Conrad Meyer <cem@FreeBSD.org> wrote: >> >> On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter >> <oliver.pinter@hardenedbsd.org> wrote: >>> strlcpy instead or adjust the p->vendors size? >> >> Neither. The buffer is intentionally not nul-terminated. The >> coverity reports are false positives. > > Then wouldn=E2=80=99t memcmp be better? No, memcmp doesn't do anything like strncpy. memcpy wouldn't hurt but I don't see any reason to change it. Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXXKFwtV0CvjLXA_8mnkP1tCz9ZNf_%2BUpiZc%2BUAAGPyoA>