Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Apr 2007 08:42:53 -0700
From:      Nate Lawson <nate@root.org>
To:        =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libfetch fetch.3 ftp.c
Message-ID:  <462CD3FD.6080300@root.org>
In-Reply-To: <86abwzio7t.fsf@dwp.des.no>
References:  <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote:
> Nate Lawson <njl@FreeBSD.org> writes:
>>   Log:
>>   Add back the original behavior of changing the entire directory path at
>>   once (CWD a/b/c vs. 3 CWDs).  If an error occurs, we fall back to the default
>>   method of a single CWD per directory element.  Since this is technically
>>   a violation of the basic FTP RFC
> 
> Actually, it's a violation not of RFC959 (FTP) but of RFC1738 which
> indicates how FTP URLs should be handled.
> 
>>                                   , this behavior is under a compile-time
>>   option FTP_COMBINE_CWDS and is off by default.  It should work with most
>>   Unix-based FTP daemons and can save latency.
> 
> Thanks.
> 
> I'm going to set up a ports fetch run with FTP_COMBINE_CWDS enabled to
> see how it works out in the ugly, real world.  If it works out well, I
> might replace the #ifdef with a command-line option or environment
> variable for "strict RFC conformance".

Thanks for doing the testing.

-- 
Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?462CD3FD.6080300>