Date: Sun, 29 Jun 2008 10:57:16 -0700 From: Xin LI <delphij@delphij.net> To: Jens Rehsack <rehsack@web.de> Cc: FreeBSD GNOME Users <gnome@FreeBSD.ORG>, delphij@FreeBSD.ORG Subject: Re: ports/124115: net/openldap24-server: Auto-Detect OpenLDAP version and modify knobs according to common names Message-ID: <4867CCFC.6010705@delphij.net> In-Reply-To: <4867705F.3040408@web.de> References: <485E6E98.9000106@web.de> <1214677236.86194.7.camel@shumai.marcuscom.com> <4867705F.3040408@web.de>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jens Rehsack wrote:
| Joe Marcus Clarke wrote:
|> On Sun, 2008-06-22 at 15:24 +0000, Jens Rehsack wrote:
|>> Hi,
|>>
|>> I tried a little around with the submitted patch and detected 2 issues:
|>> 1) I had a typo in line 37 of bsd.ldap.mk
|>> -DEFAULT_OPENLDPAP_VER?= 23
|>> +DEFAULT_OPENLDAP_VER?= 23
|>> It's quite easy to fix it ;)
|>>
|>> 2) A port (security/seahorse) checks in line 72 for
|>> ${WANT_OPENLDAP_VER},
|>> which is deprecated. By the way - it doesn't want to check for
|>> WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
|>> Doing this would require to split the "code" in bsd.ldap.mk into a
|>> pre- and post-part, not handle everything in the post-part.
|>>
|>> What do you think?
|>
|> I've been away for a week and a half. Has anything come of this?
|
| Welcome back. Seems, that there're some more people are away ;-)
|
|> I have no objection to making seahorse more flexible in terms of LDAP
|> support if the underlying code supports it.
|
| But it is in the moment. The question is: how to deal with it? The
| provided patch would be able to force openldap-24, but that may
| conflict when openldap-23 is installed ...
I think we would eventually switch using openldap-24 as default. What I
am concerning about is that switching to openldap-24 could cause some
breakage, that's why I requested a pointyhat build... I'm ready fixing
issues (if there is any).
Cheers,
- --
Xin LI <delphij@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEARECAAYFAkhnzPwACgkQi+vbBBjt66CUUwCgwM0MpfFDY8mfnFZBsXpLGhOX
Hs0AoLxnkKURv5Bijz9KiyX8l7O3j9wK
=Roke
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4867CCFC.6010705>