From owner-trustedbsd-cvs@FreeBSD.ORG  Mon Jan 22 16:02:49 2007
Return-Path: <owner-trustedbsd-cvs@FreeBSD.ORG>
X-Original-To: trustedbsd-cvs@freebsd.org
Delivered-To: trustedbsd-cvs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4E58116A413
	for <trustedbsd-cvs@freebsd.org>; Mon, 22 Jan 2007 16:02:49 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id B59DA13C471
	for <trustedbsd-cvs@freebsd.org>; Mon, 22 Jan 2007 16:02:48 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by cyrus.watson.org (Postfix) with ESMTP id D127B49ADB
	for <trustedbsd-cvs@trustedbsd.org>;
	Mon, 22 Jan 2007 11:02:43 -0500 (EST)
Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54])
	by mx2.freebsd.org (Postfix) with ESMTP id 43F6255DA5;
	Mon, 22 Jan 2007 16:02:42 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3BDF316A40A; Mon, 22 Jan 2007 16:02:42 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1AABF16A402
	for <perforce@freebsd.org>; Mon, 22 Jan 2007 16:02:42 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 09D9513C442
	for <perforce@freebsd.org>; Mon, 22 Jan 2007 16:02:42 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0MG2fYs025515
	for <perforce@freebsd.org>; Mon, 22 Jan 2007 16:02:41 GMT
	(envelope-from millert@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0MG2fa8025509
	for perforce@freebsd.org; Mon, 22 Jan 2007 16:02:41 GMT
	(envelope-from millert@freebsd.org)
Date: Mon, 22 Jan 2007 16:02:41 GMT
Message-Id: <200701221602.l0MG2fa8025509@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	millert@freebsd.org using -f
From: Todd Miller <millert@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 113343 for review
X-BeenThere: trustedbsd-cvs@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD CVS and Perforce commit message list
	<trustedbsd-cvs.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>, 
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-cvs>
List-Post: <mailto:trustedbsd-cvs@FreeBSD.org>
List-Help: <mailto:trustedbsd-cvs-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>,
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2007 16:02:49 -0000

http://perforce.freebsd.org/chv.cgi?CH=113343

Change 113343 by millert@millert_macbook on 2007/01/22 16:01:43

	Ports returned by ipc_port_alloc_kernel() are not locked.

Affected files ...

.. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#10 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#10 (text+ko) ====

@@ -122,9 +122,6 @@
 	lh->lh_port = ipc_port_alloc_kernel();
 	lh->lh_type = LABELH_TYPE_KERN;
 	lh->lh_references = 1;
-	ip_unlock(lh->lh_port);
-
-	/* Must call ipc_kobject_set() with port unlocked. */
 	ipc_kobject_set(lh->lh_port, (ipc_kobject_t)lh, IKOT_LABELH);
 
 	return (lh);