From owner-freebsd-doc@FreeBSD.ORG Sat Oct 26 16:50:02 2013 Return-Path: Delivered-To: freebsd-doc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 10D15FC2 for ; Sat, 26 Oct 2013 16:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F37EE2758 for ; Sat, 26 Oct 2013 16:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9QGo1TK093234 for ; Sat, 26 Oct 2013 16:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9QGo1RZ093233; Sat, 26 Oct 2013 16:50:01 GMT (envelope-from gnats) Date: Sat, 26 Oct 2013 16:50:01 GMT Message-Id: <201310261650.r9QGo1RZ093233@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org Cc: From: Sergey Kandaurov Subject: Re: docs/183333: Misnamed constant in bpf(4) X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Sergey Kandaurov List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Oct 2013 16:50:02 -0000 The following reply was made to PR docs/183333; it has been noted by GNATS. From: Sergey Kandaurov To: Mats Erik Andersson Cc: bug-followup@FreeBSD.org Subject: Re: docs/183333: Misnamed constant in bpf(4) Date: Sat, 26 Oct 2013 20:49:50 +0400 The bpf(4) documentation states that the example is taken from the Reverse ARP Daemon. rarpd is tightly coupled with BPF. This macro is actually used there mapped to ARPOP_REVREQUEST. From rarpd code snippet's p.o.v. this EXAMPLES is correct, but is not compilable as is without adding this mapping there. The REVARP_REQUEST localism is probably came from SunOS? (and RFC1931). This macro does not exist in net/if_arp.h (in any BSD except Solaris) and is/was probably used for source compatibility with SunOS. The ARPOP_REVREQUEST macro sits there since 1992 (4.4BSD). SunOS took if_arp.h from UCB on 1/24/86 and added REVARP_REQUEST on its own. It seems to not have ARPOP_REVREQUEST. wpaul modified rarpd.c in r19859 to use REVARP_REQUEST (it was ARPOP_REVREQUEST there originally r6823). The bpf(4) man page came in with r5882 from 1.1.5, and it was REVARP_REQUEST there. It was REVARP_REQUEST in rarpd as found in 4.3BSD-UWisc copyrighted by Sun Micro dated 86/02/05 which is before 1992. -- wbr, pluknet