From owner-svn-src-all@FreeBSD.ORG  Tue Jan 20 19:14:43 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id ED4BED5F;
 Tue, 20 Jan 2015 19:14:43 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5F5D2D08;
 Tue, 20 Jan 2015 19:14:43 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0KJEc14042390
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 20 Jan 2015 21:14:38 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0KJEc14042390
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t0KJEcbi042389;
 Tue, 20 Jan 2015 21:14:38 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 20 Jan 2015 21:14:38 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Subject: Re: svn commit: r277421 - head/sys/powerpc/powerpc
Message-ID: <20150120191438.GL42409@kib.kiev.ua>
References: <201501201621.t0KGLx26096724@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201501201621.t0KGLx26096724@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 19:14:44 -0000

On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote:
> Author: nwhitehorn
> Date: Tue Jan 20 16:21:59 2015
> New Revision: 277421
> URL: https://svnweb.freebsd.org/changeset/base/277421
> 
> Log:
>   There does not seem to be any reason to acquire GIANT here. Follow amd64
>   in removing it.
>   
>   MFC after:	1 month
> 
> Modified:
>   head/sys/powerpc/powerpc/mem.c
> 
> Modified: head/sys/powerpc/powerpc/mem.c
> ==============================================================================
> --- head/sys/powerpc/powerpc/mem.c	Tue Jan 20 15:45:09 2015	(r277420)
> +++ head/sys/powerpc/powerpc/mem.c	Tue Jan 20 16:21:59 2015	(r277421)
> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio,
>  	cnt = 0;
>  	error = 0;
>  
> -	GIANT_REQUIRED;
> -

This is not an acquisition, to be pedantic.  Really, it is cdevsw which
has D_NEEDGIANT flag which acquires Giant.  After architectures get
rid of GIANT_REQUIRED, flag can be removed.