From owner-cvs-all@FreeBSD.ORG  Sun Oct 30 13:47:03 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B1D8816A41F;
	Sun, 30 Oct 2005 13:47:03 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3896A43D53;
	Sun, 30 Oct 2005 13:47:02 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id CC0CF1A3C28; Sun, 30 Oct 2005 05:47:02 -0800 (PST)
Date: Sun, 30 Oct 2005 05:47:02 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: David Xu <davidxu@FreeBSD.org>
Message-ID: <20051030134702.GK32289@elvis.mu.org>
References: <200510300212.j9U2CnWl089007@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200510300212.j9U2CnWl089007@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: alc@freebsd.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys aio.h signal.h signalvar.h src/sys/kern
	syscalls.master vfs_aio.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2005 13:47:03 -0000

Does this modify the size/layout of the struct sigevent and aiocb
to the point where apps need a recompile?  If so we
should we have compat functions for AIO?  Ei, struct "osigevent"
and "oaiocb" and corresponding compat functions for AIO?

I understand that it's annoying but AIO has been an interface around
since 4.x.

Now might also be a good time to add padding to aiocb and possibly
sigevent.

-Alfred

* David Xu <davidxu@FreeBSD.org> [051029 20:13] wrote:
> davidxu     2005-10-30 02:12:49 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/sys              signal.h signalvar.h aio.h 
>     sys/kern             syscalls.master vfs_aio.c 
>   Log:
>   Fix sigevent's POSIX incompatible problem by adding member fields
>   sigev_notify_function and sigev_notify_attributes. AIO syscalls
>   use sigevent, so they have to be adjusted.
>   
>   Reviewed by:    alc
>   
>   Revision  Changes    Path
>   1.203     +10 -8     src/sys/kern/syscalls.master
>   1.199     +63 -9     src/sys/kern/vfs_aio.c
>   1.31      +2 -1      src/sys/sys/aio.h
>   1.49      +18 -15    src/sys/sys/signal.h
>   1.72      +9 -0      src/sys/sys/signalvar.h

-- 
- Alfred Perlstein