Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Aug 1999 07:20:19 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, green@FreeBSD.org
Subject:   Re: cvs commit: src/libexec/telnetd sys_term.c 
Message-ID:  <21731.934176019@critter.freebsd.dk>
In-Reply-To: Your message of "Mon, 09 Aug 1999 14:03:31 %2B1000." <199908090403.OAA21041@godzilla.zeta.org.au> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <199908090403.OAA21041@godzilla.zeta.org.au>, Bruce Evans writes:
>>green       1999/08/08 19:19:38 PDT
>>
>>  Modified files:
>>    libexec/telnetd      sys_term.c 
>>  Log:
>>  Add a missing include (sys/queue.h for sys/tty.h SLIST usage.)
>>  
>>  Revision  Changes    Path
>>  1.22      +2 -1      src/libexec/telnetd/sys_term.c
>
>Wrong fix.  <sys/queue.h> is not a prerequisite of <sys/tty.h> (recent
>breakage of <sys/tty.h> doesn't count).
>
>The following script lists (in the source) almost-minimal prerequisites
>for most FreeBSD-1999-May-14 headers as a side effect of checking for
>prerequisites.  Ugly, isn't it?  Don't make it worse.

Yeah, I think the right fix is to include <sys/queue.h> in
<sys/types.h> and remove all explicit includes to it.

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21731.934176019>