Date: Thu, 25 Oct 2007 12:09:21 -0700 From: LI Xin <delphij@delphij.net> To: Andrey Chernov <ache@nagual.pp.ru>, d@delphij.net, Scott Long <scottl@samsco.org>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c Message-ID: <4720E9E1.7000900@delphij.net> In-Reply-To: <20071025190019.GA16187@nagual.pp.ru> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9372C5B26114F9F41A4DDFE6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 09:44:06AM -0700, LI Xin wrote: >> Andrey Chernov wrote: >>> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: >>>> Andrey A. Chernov wrote: >>>>> ache 2007-10-15 09:51:30 UTC >>>>> FreeBSD src repository >>>>> Modified files: >>>>> lib/libc/locale utf8.c Log: >>>>> Add comment explaining __mb_sb_limit trick here. >>>>> Revision Changes Path >>>>> 1.16 +5 -0 src/lib/libc/locale/utf8.c >>>> When is the ABI damage from this going to be fixed? >>> There is no ABI damage in -current. >> Do we really need to expose __mb_sb_limit outside libc? >=20 > Yes, it is used in inlines compiled each time ctype.h included. Yes, I noticed that. So the problem would be, if a program has included ctype.h (_ctype.h) then it has the potential to require the symbol, which does not exist in previous releases. Having __inline functions sounds reasonable to me, though, because these functions are really small and may be called frequently. Maybe we can think out a way of avoiding the addition? It sounds like that potentially we will have trouble running binaries compiled on 6.3-R on 6.2-R systems, while this is acceptable IMO it is not very interesting for user community :-) Cheers, --=20 Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig9372C5B26114F9F41A4DDFE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHIOnhOfuToMruuMARCkhMAJkBdIU8CJg4kjJBtVeJgquPPlKldwCZAYcr wpSbIb3xfLO4oG5e3o+MF6Y= =Gw2e -----END PGP SIGNATURE----- --------------enig9372C5B26114F9F41A4DDFE6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4720E9E1.7000900>