Date: Sat, 28 Mar 2015 13:33:49 -0600 From: Ian Lepore <ian@freebsd.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r280790 - in head/sys: conf dev/hwpmc Message-ID: <1427571229.20823.1.camel@freebsd.org> In-Reply-To: <E36D0026-3B7D-4078-99AF-D49C408EC997@FreeBSD.org> References: <201503281857.t2SIvErQ096549@svn.freebsd.org> <E36D0026-3B7D-4078-99AF-D49C408EC997@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2015-03-28 at 19:01 +0000, Bjoern A. Zeeb wrote: > > On 28 Mar 2015, at 18:57 , Bjoern A. Zeeb <bz@FreeBSD.org> wrote: > > > > Author: bz > > Date: Sat Mar 28 18:57:13 2015 > > New Revision: 280790 > > URL: https://svnweb.freebsd.org/changeset/base/280790 > > > > Log: > > Remove all the handcrafted assembly in hwpmc_armv7.c and use the > > common (autogenerated) versions. Removes extra vertical space, > > and makes it easier to grep for usage throughout the tree. > > Conditionally compile only for arm6 [1] (yes sounds odd but is right). > > > > Submitted by: andrew [1] > > Reviewed by: gnn, andrew (ian earlier version I think) > > and ian (I missed the official review for the latest version; sorry) > No problem. IMO, if a commit references a phab revision, there's no need to list individual reviewers as well, since the phab info already contains all that. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1427571229.20823.1.camel>