Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 May 2004 21:12:45 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        John Polstra <jdp@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/boot/i386/libi386 biosacpi.c
Message-ID:  <20040513211215.K93408@root.org>
In-Reply-To: <20040514012935.023B916A545@hub.freebsd.org>
References:  <20040514012935.023B916A545@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 May 2004, John Polstra wrote:
> jdp         2004/05/13 18:29:21 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/boot/i386/libi386 biosacpi.c
>   Log:
>   Fix a potential stack buffer overflow on systems whose ACPI OEMID
>   fills its field (6 characters).  In that case the OEMID is not
>   null-terminated, and the sprintf that was used would copy up to the
>   next null byte, which could be pretty far away.
>
>   Revision  Changes    Path
>   1.8       +2 -2      src/sys/boot/i386/libi386/biosacpi.c

Thanks for fixing this and running it past me for review.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040513211215.K93408>