From owner-freebsd-current Thu Feb 27 17:41:06 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA00656 for current-outgoing; Thu, 27 Feb 1997 17:41:06 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id RAA00650 for ; Thu, 27 Feb 1997 17:41:02 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <15746(7)>; Thu, 27 Feb 1997 17:38:58 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177476>; Thu, 27 Feb 1997 17:38:46 -0800 To: Chuck Robey cc: FreeBSD current Subject: Re: fixing fsck In-reply-to: Your message of "Thu, 27 Feb 97 15:21:01 PST." Date: Thu, 27 Feb 1997 17:38:40 PST From: Bill Fenner Message-Id: <97Feb27.173846pst.177476@crevenia.parc.xerox.com> Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Chuck Robey wrote: >In dinode.h, all the time related fields, which used to be >timespec structs (members tv_sec and tv_usec) are now int32_t, which >doesn't have any logical connection to their time-related usage at all. >I can't understand the reasoning behind this change. If you look carefully at the diffs, the old struct timespec di_atime; changed to int32_t di_atime; int32_t di_atimensec; which makes it relatively clear what happened, especially if you look at the byte offsets in the comments. di_atime.ts_sec became di_atime, and di_atime.ts_nsec became di_atimensec. The diff also describes the reason for this change: + * This structure defines the on-disk format of a dinode. Since + * this structure describes an on-disk structure, all its fields + * are defined by types with precise widths. Bill