From owner-svn-src-all@freebsd.org Tue Feb 7 12:55:12 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FCA3CD4393; Tue, 7 Feb 2017 12:55:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 317DB1137; Tue, 7 Feb 2017 12:55:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id v77so28068086wmv.0; Tue, 07 Feb 2017 04:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=L+7gt/Vs/Z+2cYv4QhuUOxd0RjxIz3QYyvYYMEkHYAE=; b=Rx7gKHSDRfZ0/1VPWaB0PmYkpORYwdrHyv9u6QLIaB/SYREdvCG3la5x3fwc0bAj4z OHLBW5Ap0FCo1pQFtD4Q6m3LO3V9zFT5/T4nnhD3/zRtN8OgtbdmL5AwINriMlop+RXG nWx1K4TvA/eprhuh1qEH7bkQHxQGV3vXrieOIQbygkN5IO+hGtc/uHJs8CERT/xzu9VX lefTkZgG5emCHIR+gxiy81jw9PmD14cj2YaJ+im1oL/httemqdHr8wL/cS+rMbDtxZaO z3Qg8aIt/J1OAtbfMrFVK3didBRISuZXrGIf8iplY/pGlDkRB9tEmsRN3pohiCz2QYSk DX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=L+7gt/Vs/Z+2cYv4QhuUOxd0RjxIz3QYyvYYMEkHYAE=; b=E9UfUV6zP48HZThusITZ5UEswoMzcSH2jA3oNcfWK+kiaJzaLZiFkFZ9MW0+8TnGCi jp7pCM8l9NcyyaD8wIxuBhBOCourm+RRWr6L6NNR98yGDKBUs589SrS/hrXN45JuuvKp R7xrPSkOC24Wk5Du/yJglXvcvOHKupsZpNODzgWb0f3+ZoJKnClHAH09lzkGUDyyLv1+ MC17CYk+NRJwAmTU3F2oZAeoG/c6u2k1urUGjsHxi6S0Bahluz24JK4XwTvWqrDbjO2t SmKcWHfMubAZJEHdYYnV8jQbxO7joyjST0MEKUQVYg0JaNtvl+ViSMijKIqcSX8VdRpl 2RVg== X-Gm-Message-State: AMke39nlOvmzz5W3Jx2C1RfZVYYMyFcUD3u5Yas1BQaOdlLmsObQ8bfwQZ+6ewbvn3gsXw== X-Received: by 10.28.148.76 with SMTP id w73mr13279908wmd.74.1486472110449; Tue, 07 Feb 2017 04:55:10 -0800 (PST) Received: from brick (global-5-142.nat-2.net.cam.ac.uk. [131.111.5.142]) by smtp.gmail.com with ESMTPSA id 8sm2843670wmg.1.2017.02.07.04.55.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 04:55:09 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Tue, 7 Feb 2017 12:55:08 +0000 From: Edward Tomasz Napierala To: Konstantin Belousov Cc: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313352 - in head/sys: compat/cloudabi compat/freebsd32 compat/linux vm Message-ID: <20170207125508.GA62670@brick> Mail-Followup-To: Konstantin Belousov , John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702062057.v16KvCtI069664@repo.freebsd.org> <2958370.34Dmljdf7f@ralph.baldwin.cx> <20170207083909.GX2092@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170207083909.GX2092@kib.kiev.ua> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 12:55:12 -0000 On 0207T1039, Konstantin Belousov wrote: > On Mon, Feb 06, 2017 at 03:03:11PM -0800, John Baldwin wrote: > > On Monday, February 06, 2017 08:57:12 PM Edward Tomasz Napierala wrote: > > > Author: trasz > > > Date: Mon Feb 6 20:57:12 2017 > > > New Revision: 313352 > > > URL: https://svnweb.freebsd.org/changeset/base/313352 > > > > > > Log: > > > Add kern_vm_mmap2(), kern_vm_mprotect(), kern_vm_msync(), kern_vm_munlock(), > > > kern_vm_munmap(), and kern_vm_madvise(), and use them in various compats > > > instead of their sys_*() counterparts. > > > > > > Reviewed by: ed, dchagin, kib > > > MFC after: 2 weeks > > > Sponsored by: DARPA, AFRL > > > Differential Revision: https://reviews.freebsd.org/D9378 > > > > I know kib@ suggested kern_vm_ instead of the vm_ you had suggested, > > but just kern_ would be more consistent. That is what we have done with > > every other system call. (e.g. there isn't kern_socket_bind, kern_socket_listen, > > etc., but just kern_bind() and kern_listen()). > > Note that the kern_vm_* functions are not quite regular syscall helpers. > The big issue with them, which caused my suggestion, is that the > functions cannot be declared in sys/syscallsubr.h, because their > declarations depend on the vm/*.h namespace. Exactly; they use vm-specific types (vm_offset_t, for example). And I wanted to avoid changing the types all over the place, at least for now.