From owner-cvs-all@FreeBSD.ORG  Fri Jan  6 10:59:24 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BAFD416A41F;
	Fri,  6 Jan 2006 10:59:24 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1D17A43D6A;
	Fri,  6 Jan 2006 10:59:23 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id B0A09BC66;
	Fri,  6 Jan 2006 10:59:21 +0000 (UTC)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 04 Jan 2006 20:26:22 +0100."
	<20060104192622.GA17950@garage.freebsd.pl> 
Date: Fri, 06 Jan 2006 11:59:21 +0100
Message-ID: <850.1136545161@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/dcons dcons_os.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2006 10:59:24 -0000

In message <20060104192622.GA17950@garage.freebsd.pl>, Pawel Jakub Dawidek writes:
>On Wed, Jan 04, 2006 at 09:20:42AM +0000, Poul-Henning Kamp wrote:
>+> phk         2006-01-04 09:20:41 UTC
>+> 
>+>   FreeBSD src repository
>+> 
>+>   Modified files:
>+>     sys/dev/dcons        dcons_os.c 
>+>   Log:
>+>   Use ttyalloc() instead of ttymalloc()
>[...]
>+> -	tp = dev->si_tty = ttymalloc(dev->si_tty);
>+> +	tp = dev->si_tty;
>
>This was your intention not 'tp = dev->si_tty = ttyalloc();'?

Yes, the ttyalloc() happens in dcons_attach_port()

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.