Date: Fri, 9 Apr 2010 20:58:45 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Julian Elischer <julian@elischer.org> Cc: virtualization@freebsd.org, anchie@freebsd.org, Anders Hagman <anders.hagman@halleforshunden.org> Subject: Re: dummynet and vnet kernel panic Message-ID: <20100409185845.GA56240@onelab2.iet.unipi.it> In-Reply-To: <4BBF7387.5010604@elischer.org> References: <4BBCE3EE.506@halleforshunden.org> <20100407203802.GA91356@onelab2.iet.unipi.it> <4BBCF17F.4000408@elischer.org> <20100409141722.GA53191@onelab2.iet.unipi.it> <4BBF7387.5010604@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 09, 2010 at 11:35:51AM -0700, Julian Elischer wrote: > On 4/9/10 7:17 AM, Luigi Rizzo wrote: ... > >former global variables are now mostly in a single struct, dn_cfg. > >There are however 150 lines where the global variable is used, so > >I am bit scared at renaming all of these occurrences from dn_cfg > >to V_dn_cfg. I'd rather follow a different approach, i.e > > it woudl work but we avoided that way because we specifically wantet > to be able to see at a glance whether virtualization is involved > somewhere. The change of name is just a single vi command.. Yes but the V_visual effect is V_horrible! Besides, all per-vimage state will be in a single variable, it will be easy for the programmer to know which is which. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100409185845.GA56240>