Date: Tue, 07 Apr 2015 20:00:23 +0200 From: John Marino <freebsd.contact@marino.st> To: Bryan Drewery <bdrewery@FreeBSD.org>, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383184 - in head/devel/libc++: . files Message-ID: <55241B37.9090108@marino.st> In-Reply-To: <55241824.2060108@FreeBSD.org> References: <201504040022.t340MwUc082274@svn.freebsd.org> <55240C73.9050209@FreeBSD.org> <55241047.50102@marino.st> <55241824.2060108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/7/2015 19:47, Bryan Drewery wrote: > On 4/7/2015 12:13 PM, John Marino wrote: >> Had I create the patch a week later, then I would have had to >> rework my patch. Sometimes this happen. > > Dim's PR is from January. PR 196536. Like I said, when a PR goes stale for 8+ weeks, that can happen, especially on unmaintained ports. >>> I think it will be simpler to use CPPFLAGS+=-D__FreeBSD__ to >>> cover most of these cases without patches. >> >> Well, it didn't. > > Setting __FreeBSD__ and __FreeBSD_version to 901501 would be the > same effect. Which is exactly the hack I was using, but with the other generic work I decided to fix this unmaintained port properly for dfly. > The staging/check-plist work resulted in not needing to check options > or remove various files from the stagedir. Removing stuff like that > is under the cleanup blanket. Generally NOPS in port files are just > removed. I don't see the issue in having the stagedir match what's installed. Obviously I ran into this and it caused an issue for me. If it's some kind of crusade for you then remove it. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55241B37.9090108>