Date: Tue, 19 Dec 2017 10:04:21 +1100 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r326923 - stable/10/usr.bin/calendar/calendars Message-ID: <20171218230421.GE4376@eureka.lemis.com> In-Reply-To: <20171218142306.zy46plfrctwhrcwg@ivaldir.net> References: <201712172212.vBHMCwYH026523@repo.freebsd.org> <20171218142306.zy46plfrctwhrcwg@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Ns7jmDPpOpCD+GE/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 18 December 2017 at 15:23:06 +0100, Baptiste Daroussin wrote: > On Sun, Dec 17, 2017 at 10:12:58PM +0000, Greg Lehey wrote: >> Author: grog >> Date: Sun Dec 17 22:12:57 2017 >> New Revision: 326923 >> URL: https://svnweb.freebsd.org/changeset/base/326923 >> >> Log: >> Correct character set. > > You are "correcting" a UTF-8 character into a ISO-8859 character directly in > branch 10. > > This looks wrong in multiple way: > 1. everything was converted into UTF-8 in 2011 on purpose For small values of "everything", maybe. I've checked three files: calendar.history, fr_FR.ISO8859-1/calendar.fetes and de_DE.ISO8859-1/calendar.geschichte. Only the first was in UTF-8. It sounds like a good idea to convert the files to UTF-8, but it has to be done to all of them. And how about adding some information about the preferred character set? We could kill two birds with one stone and add this to the top of each file: /* -*- coding: utf-8 -*- That would clarify things and also tell Emacs the character encoding automatically. Even for non-Emacs users it would be an advantage. > 2. why directly to the 10 branch and no in head? Finger trouble. Mea culpa. I'll back it out when we come to an agreement on how to do the rest. Greg -- Sent from my desktop computer. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. This message is digitally signed. If your Microsoft mail program reports problems, please read http://lemis.com/broken-MUA --Ns7jmDPpOpCD+GE/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlo4SXUACgkQIubykFB6QiPs3gCgkKWTTZPNknnSn1rQPTunXGgs kfYAnRgr7YnEhSIjyJMTgUa/YoHgdcc+ =PchE -----END PGP SIGNATURE----- --Ns7jmDPpOpCD+GE/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171218230421.GE4376>