From owner-svn-src-all@freebsd.org Tue Aug 11 15:10:57 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1E2F99FF57 for ; Tue, 11 Aug 2015 15:10:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 84013EEA for ; Tue, 11 Aug 2015 15:10:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pdrg1 with SMTP id g1so84629557pdr.2 for ; Tue, 11 Aug 2015 08:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=E2wDHE/zTFcej2Uja002sZx5bZ0ExH1FtNq1TUGs6Uo=; b=J5lv/hxg5Ar4xbT/EF9I/r1wy8SQCDCB70W0OtINRt3arl4tSDQliVYXzzooH9Hyfl l/bHiupt1Y2vFyxQi8tD9rCr99SOunbMvHfSOrFLmMSn7DMf14QZKa6v3p8sIP3HGLZZ JUTqVt4ZU2jhXLiFmTSSC+SKX8iJUCXZ4LPaWIcnXXPmyRosF6pBKXTbXtiBLymV7jWj NVnrs3WvGplvfY1/9+WJcfLVCXnNiYZp3NeP0dKh/MjHGUlkCQOb1pt3c5Fc0QbP7Wfx SceJQ6CuUVbLv+QzjNFEBHgL7emEKKqBKucsNaTIQaOxPtgQEgJJRALF5q4dJ1PFShWy 6nzQ== X-Gm-Message-State: ALoCoQkk0YOaeRjIY3CIESpey4kxzXHRCJLN1Qk976uIkFdNnDGvz1X4KFs2gZdiRyOqo3XsaN2c X-Received: by 10.70.3.98 with SMTP id b2mr57046986pdb.107.1439305850288; Tue, 11 Aug 2015 08:10:50 -0700 (PDT) Received: from [100.127.128.155] ([69.53.245.15]) by smtp.gmail.com with ESMTPSA id da17sm3041528pac.29.2015.08.11.08.10.48 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 11 Aug 2015 08:10:49 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_18A42306-2BC7-4C21-A695-ADDAF3EC4FD6"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: <1439301209.4375.40.camel@FreeBSD.org> Date: Tue, 11 Aug 2015 09:10:46 -0600 Cc: Jan Beich , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Message-Id: References: <201508091258.t79CwvGj027161@repo.freebsd.org> <1439301209.4375.40.camel@FreeBSD.org> To: Koop Mast X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2015 15:10:57 -0000 --Apple-Mail=_18A42306-2BC7-4C21-A695-ADDAF3EC4FD6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 11, 2015, at 7:53 AM, Koop Mast wrote: >=20 > On Mon, 2015-08-10 at 02:15 +0200, Jan Beich wrote: >> Koop Mast writes: >>=20 >>> Author: kwm (ports committer) >>> Date: Sun Aug 9 12:58:56 2015 >>> New Revision: 286524 >>> URL: https://svnweb.freebsd.org/changeset/base/286524 >>>=20 >>> Log: >>> Add a new group named 'video' with the id of 44. And make drm >>> create >>> devices in /dev/dri/ with this new group. >>=20 >> Would 'video' group include capture devices as well? Linux seems to >> mix >> /dev/nvidia*, /dev/fb* and /dev/video* all under same group despite >> all of them have different attack vectors. >=20 > We could extend this, but the only example I had where the dri = devices. > Also webcamd already chmod's it's devices: > % ll /dev/video0 > crw-rw---- 1 webcamd webcamd 0x9a Aug 10 07:35 /dev/video0 >=20 > I'm unsure if nvidia makes any /dev devices since it been ages since I > had one in a machine of mine. >=20 >>> Modified: head/sys/dev/drm/drmP.h >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- head/sys/dev/drm/drmP.h Sun Aug 9 12:20:22 2015 >>> (r286523) >>> +++ head/sys/dev/drm/drmP.h Sun Aug 9 12:58:56 2015 >>> (r286524) >>> @@ -175,7 +175,7 @@ SYSCTL_DECL(_hw_drm); >>>=20 >>> #define DRM_DEV_MODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP) >>> #define DRM_DEV_UID 0 >>> -#define DRM_DEV_GID 0 >>> +#define DRM_DEV_GID 44 /* "video" group */ >>=20 >> Why hardcode? Linux often uses udev(7) rules to assign a group which >> on >> FreeBSD can easily be translated into devd.conf(5) or devfs.rules(5). >>=20 >> Having 'video' assigned by kernel wouldn't eliminate having to run >> mergemaster/etcupdate + pw groupmod on upgrade. >=20 > I find this way easier to do. However with the devd.conf(5) or > devfs.rules(5) someone still needs to up date the /etc and pw = groupmod. devd.conf isn=E2=80=99t the place for this. This is pure devfs.rules. Warner --Apple-Mail=_18A42306-2BC7-4C21-A695-ADDAF3EC4FD6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVyhB3AAoJEGwc0Sh9sBEAg54QAIxT7XZBAk3NT2AnsgDvOYFl CaPGFengI9bQZ84U7yeV+IAbHmE+JgUsGnfZSrgazee+55Shl7HS5hBjP8Dmezh6 jklC3P2gdKrigwpP0jnD0wEgNW4FlRYgcGsskTGirHe1bG2x7rcVf650vdA9oBU9 gBTYzGEOB35fd0NeUj+UX6xtYdOPE5MA8jA3IFkozLSFpiWQr6FCOYczGDaYk0u7 6qmD7tKT1UX+d3GkO9FvzyFqAD2872cGJo/ljsfAKxH40AgEzbrl90oKTpmh8hiU AzmH0vt/PIf+o1STa3VWblKR1JQGXCT0qjfRhT64WAOCyWA8zsPCSpeV2ilrgytB HspRWqywZ4epdwQYikqIKx3X4okFsObkpGGNTzn5P0m+YJa1ynqbNHfgf8Y4PLYn xHh/Wo1AfPvEExDvM6ePtZeubWp+mnVXLVpqQI3IzUun/qSbByBlZlG9JmzVt3Cf tsrkOIcnNFFWwGjUuLQ9BJZXkRkwzXFaH0FPPm7ucuvIWY5X2ElFA18mE/M9gBox grKZSiV8NVgKZP2XoMs+5EUpo88uCv0auKnlYz4FKhOsDPq1Wf5qUrj0bNiPwpUm FLcugaCvDkc+DzGhERr4a0ng1mgsrPo4eg3YHj9cMLOLPfiIfBAgRVcdojac49CJ BTMreEjigDuvogWNpSfD =tus0 -----END PGP SIGNATURE----- --Apple-Mail=_18A42306-2BC7-4C21-A695-ADDAF3EC4FD6--