Date: Thu, 07 Feb 2019 08:40:11 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 235563] New port: emulators/teoemulator: Thomson TO8 Emulator Message-ID: <bug-235563-7788-DEMAuHOCNV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-235563-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-235563-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235563 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch, needs-qa Status|New |Open --- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> --- Any reason to name the package teoemulator instead of just teo? AFAICT the teo package name is still free. XUSES=3D gmake pkgconfig This is missing USES=3Dgnome. Please define DEVELOPER=3Dyes in your /etc/make.conf when testing ports to enable more QA warnings. XINSTALLS_ICONS=3D no The framework checks if INSTALLS_ICONS is defined or not. The value doesn't matter much. So if the intent is to not have a gtk-update-icon-cache dependency, then this should be dropped, otherwise it should be "yes" for consistency with other ports. It looks like you can safely remove this. XPLIST_DIRS=3D ${DATADIR_REL}/rom \ X ${DATADIR_REL}/icons XROM_FILES=3D basic1 basic512 expl extramon monitor1 monitor2 XICON_FILES=3D leave run step stepover XPLIST_FILES=3D bin/teo \ X ${ROM_FILES:%=3D${DATADIR_REL}/rom/%.rom} \ X ${ICON_FILES:%=3D${DATADIR_REL}/icons/%.ico} This is too complicated. It would be nicer if you could generate a pkg-plist with `make makeplist` instead. X @echo "MAKEFILE_INC =3D makefile.lnx" > ${WRKSRC}/Makefile X @echo "include makefile.all" >> ${WRKSRC}/Makefile Use ${ECHO_CMD} instead of echo. XDEBUG_CFLAGS_OFF=3D -DNDEBUG This currently does nothing (there is no DEBUG option defined in the port). --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235563-7788-DEMAuHOCNV>