Date: Fri, 14 Mar 2008 05:28:10 GMT From: Scot Hetzel <swhetzel@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/121687: [patch] comms/gnokii: several depencancy fixes Message-ID: <200803140528.m2E5SA5C038166@www.freebsd.org> Resent-Message-ID: <200803140540.m2E5e165072890@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 121687
>Category: ports
>Synopsis: [patch] comms/gnokii: several depencancy fixes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Mar 14 05:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Scot Hetzel
>Release: FreeBSD 8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sat Feb 16 06:42:46 CST 2008 root@hp010:/usr/src/sys/amd64/compile/DV8135NR amd64
>Description:
When rebuilding comms/gnokii, I found that the port would fail to find libical.so.0. The reason for this failure is that the current ical port is installing the library as libical.so.27.
I also had the devel/pcsc-lite port installed, and when I built comms/gnokii the configure script found the pcsc-lite library and compiled in support for PC/SC cards.
Another thing I found annoying is the automatic dependency on MySQL and PostgresSQL. For instance, when the x11/kde3 is installed, it will pull in quite a few dependencies when installing the various ports that make up KDE. During the install, it will install both MySQL and PostgresSQL. A few ports down the road, it will build gnokii which will detect both *SQL ports are install, which causes gnokii to compile in support for both of them. I would prefer to have the ability to disable one or both automatic dependencies.
>How-To-Repeat:
Run `make config` and choose the MDNS_AVAHI option, then try to build the port.
Install both MySQL and PostgresSQL, then build the port. It will have a dependency on both ports.
>Fix:
The attached patch fixes these dependency problems.
Patch attached with submission follows:
Index: comms/gnokii/Makefile
===================================================================
RCS file: /home/ncvs/ports/comms/gnokii/Makefile,v
retrieving revision 1.62
diff -u -r1.62 Makefile
--- comms/gnokii/Makefile 16 Feb 2008 16:36:58 -0000 1.62
+++ comms/gnokii/Makefile 7 Mar 2008 13:57:11 -0000
@@ -42,7 +42,7 @@
.include <bsd.port.pre.mk>
-.if exists(${LOCALBASE}/lib/libical.so.0)
+.if exists(${LOCALBASE}/lib/libical.so)
WITH_ICAL= yes
.endif
@@ -50,8 +50,12 @@
WITH_USB= yes
.endif
+.if exists(${LOCALBASE}/lib/libpcsclite.so) && !defined(WITHOUT_PCSC)
+WITH_PCSC= yes
+.endif
+
.if defined(WITH_ICAL)
-LIB_DEPENDS+= ical.0:${PORTSDIR}/devel/libical
+LIB_DEPENDS+= ical.27:${PORTSDIR}/devel/libical
.endif
.if defined(WITH_USB)
@@ -62,6 +66,14 @@
CONFIGURE_ARGS+= --disable-libusb
.endif
+.if defined(WITH_PCSC)
+LIB_DEPENDS+= pcsclite.1:${PORTSDIR}/devel/pcsc-lite
+
+CONFIGURE_ARGS+= --enable-libpcsclite
+.else
+CONFIGURE_ARGS+= --disable-libpcsclite
+.endif
+
# If smsd is enabled check if MySQL or PostgreSQL are installed and
# build the modules, no switches to make this port build those, if
# you want them, just install them before this port. The port will
@@ -73,14 +85,14 @@
.else
PLIST_SUB+= SMSD=''
MAN8+= smsd.8
-.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so)
+.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so) && !defined(WITHOUT_MYSQL)
USE_MYSQL= yes
PLIST_SUB+= MSM=''
WITH_MYSQL= yes
.else
PLIST_SUB+= MSM='@comment '
.endif
-.if exists(${LOCALBASE}/bin/psql)
+.if exists(${LOCALBASE}/bin/psql) && !defined(WITHOUT_PGSQL)
USE_PGSQL= yes
PLIST_SUB+= PGM=''
WITH_PGSQL= yes
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803140528.m2E5SA5C038166>