From owner-svn-src-stable@FreeBSD.ORG Mon Nov 12 15:17:25 2012 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A902B36A; Mon, 12 Nov 2012 15:17:25 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 895A48FC20; Mon, 12 Nov 2012 15:17:25 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qACFHPhb042526; Mon, 12 Nov 2012 15:17:25 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id qACFHPS1042525; Mon, 12 Nov 2012 15:17:25 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201211121517.qACFHPS1042525@svn.freebsd.org> From: Konstantin Belousov Date: Mon, 12 Nov 2012 15:17:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r242921 - stable/9/sys/kern X-SVN-Group: stable-9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2012 15:17:25 -0000 Author: kib Date: Mon Nov 12 15:17:25 2012 New Revision: 242921 URL: http://svnweb.freebsd.org/changeset/base/242921 Log: MFC r242617: A clarification to the behaviour of the active vnode list management regarding the vnode page cleaning. Modified: stable/9/sys/kern/vfs_subr.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/kern/vfs_subr.c ============================================================================== --- stable/9/sys/kern/vfs_subr.c Mon Nov 12 14:34:46 2012 (r242920) +++ stable/9/sys/kern/vfs_subr.c Mon Nov 12 15:17:25 2012 (r242921) @@ -2547,6 +2547,9 @@ vinactive(struct vnode *vp, struct threa * Before moving off the active list, we must be sure that any * modified pages are on the vnode's dirty list since these will * no longer be checked once the vnode is on the inactive list. + * Because the vnode vm object keeps a hold reference on the vnode + * if there is at least one resident non-cached page, the vnode + * cannot leave the active list without the page cleanup done. */ obj = vp->v_object; if (obj != NULL && (obj->flags & OBJ_MIGHTBEDIRTY) != 0) {