Date: Fri, 07 Apr 2017 14:43:10 -0700 From: John Baldwin <jhb@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316622 - head/share/mk Message-ID: <2928110.Pl3rnvTUcV@ralph.baldwin.cx> In-Reply-To: <CANCZdfrgmrXS=%2BJEnPbU2tZ4WvU-zrAXN3chw31pAC%2BOf0ibFA@mail.gmail.com> References: <201704072002.v37K21Ux032932@repo.freebsd.org> <3876116.W5eNvcJ1Jh@ralph.baldwin.cx> <CANCZdfrgmrXS=%2BJEnPbU2tZ4WvU-zrAXN3chw31pAC%2BOf0ibFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 07, 2017 02:38:16 PM Warner Losh wrote: > The TARGET_CPUTYPE=mips3 likely should be the default in the build > system. We require mips3 or better ISA for our O32 ABI. Since we > require that, making the user set this always is a friction point that > we should file off. It's not like any other architecture. I'll look at > making that the overridable default if I can find a few minutes > sometime. This one in particular is kind of tricky because clang refuses to compile O32 MIPS if you set -march=mips3 (it works if you use mips2 or if you leave off the '-march' entirely). I had played with trying to cater to this by setting default CPUCFLAGS if CPUTYPE was empty but then ran into the problem that clang would need a different setting from GCC and punted. Also, the way we set CFLAGS for alternate lib builds (lib32, etc.) is kind of hackish. Possibly they should be invoking bsd.cpu.mk with a different TARGET_ARCH to avoid duplicating logic. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2928110.Pl3rnvTUcV>