Date: Wed, 01 Feb 2017 20:27:45 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 216304] Adding xn0 to bridge0 causes kernel panic Message-ID: <bug-216304-2472-9AZB2L3dLS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-216304-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-216304-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216304 --- Comment #8 from commit-hook@freebsd.org --- A commit references this bug: Author: kp Date: Wed Feb 1 20:27:38 UTC 2017 New revision: 313050 URL: https://svnweb.freebsd.org/changeset/base/313050 Log: MFC 312782 bridge: Release the bridge lock when calling bridge_set_ifcap() This calls ioctl() handlers for the different interfaces in the bridge. These handlers expect to get called in an ioctl context where it's safe for them to sleep. We may not sleep with the bridge lock held. However, we still need to protect the interface list, to ensure it doesn't get changed while we iterate over it. Use BRIDGE_XLOCK(), which prevents bridge members from being removed. Adding bridge members is safe, because it uses LIST_INSERT_HEAD(). This caused panics when adding xen interfaces to a bridge. PR: 216304 Reviewed by: ae Sponsored by: RootBSD Differential Revision: https://reviews.freebsd.org/D9290 Changes: _U stable/11/ stable/11/sys/net/if_bridge.c stable/11/sys/net/if_bridgevar.h --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-216304-2472-9AZB2L3dLS>