Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Mar 1997 14:36:59 +0100
From:      Brian Somers <brian@awfulhak.org>
To:        =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.ru>
Cc:        Brian Somers <brian@freefall.freebsd.org>, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org
Subject:   Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip  Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c  Makefile libutil.h src/sbin/startslip Makefile uucplock.c
Message-ID:  <199703311337.OAA02346@awfulhak.demon.co.uk>
In-Reply-To: Your message of "Mon, 31 Mar 1997 01:18:09 %2B0400." <Pine.BSF.3.96.970331011017.342A-100000@nagual.ru> 

next in thread | previous in thread | raw e-mail | index | archive | help
> On Sun, 30 Mar 1997, Brian Somers wrote:
> 
> >   Added:       lib/libutil  uucplock.3 uucplock.c
> >   Removed:     sbin/startslip  uucplock.c
> >   Log:
> >   Move uucplock into libutil and create a manual page.
> 
> What you do with USE_PERROR define which switch uucplock
> error loging from perror to syslog? Startslip uses syslog
> and ppp not use it. It seems that you just broke ppp since
> you left USE_PERROR define in its Makefile which unused
> now. Moreover, having library function with syslog report
> is bad idea in any case.
> 
> To fix it properly you need to change return from uucplock functions
> from int to char *, i.e. return NULL for no errors or static error
> string if error happens. Then you need to change upper level programs
> to pass this error string to perror/syslog/whatever.
> 
> -- 
> Andrey A. Chernov
> <ache@null.net>
> http://www.nagual.ru/~ache/

Oops, thanks.  I'll do the char* thing.
-- 
Brian <brian@awfulhak.org>, <brian@freebsd.org>
      <http://www.awfulhak.demon.co.uk/>;
Don't _EVER_ lose your sense of humour....





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703311337.OAA02346>