Date: Sun, 06 Jun 2004 20:11:01 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/portlint Makefileports/devel/portlint/src portlint.pl Message-ID: <40C35E35.6080803@fillmore-labs.com> In-Reply-To: <1086542154.34425.4.camel@shumai.marcuscom.com> References: <200406060106.i5616XNX076254@repoman.freebsd.org> <40C2CE39.5030402@fillmore-labs.com> <1086541625.34425.1.camel@shumai.marcuscom.com> <40C350AB.2070407@fillmore-labs.com> <1086542154.34425.4.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote: > On Sun, 2004-06-06 at 13:13, Oliver Eikemeier wrote: > >>Joe Marcus Clarke wrote: >> >>>This was supposed to solve a problem that I've personally hit a few >>>times. It was just another check to make sure PKGNAME agrees with what >>>is in distinfo. >> >>Could you give me an example? It might be interesting to add this to my >>rework of the distfiles stuff in PR 67361: >> <http://people.freebsd.org/~eik/patches/distfiles/>; >> >>If it is deemed useful to integrate distinfo into the ports Makefile one >>way or the other, it might not be worth to make efforts to check for >>stuff that might be obsolete in the future. > > For instance, when fixing hyphenated PORTNAMEs, I sometimes forget to > adjust DISTNAME, and thus the port is broken. I always remember a > portlint run, but it would never catch the problem. > > Joe So you need a consistency check without fetching the actual distfiles? I guess it makes sense to include this into bsd.port.mk, since the involved code is non-trivial, but the logic is already in place. Should I add a target to my patch, and what kind of output do you expect? -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40C35E35.6080803>